← Back to issue list

style: add typing and remove noqas

View original Github issue

Metadata

Project
craft-providers
Number
#802
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #802 (commit d9eae71) added type hints and removed noqa comments across 61 files (+1220/-972) for CRAFT-4684; approved by 3 reviewers and merged after 7 review comments.

Resolution: closed resolved

Reason: PR #802 was merged into the main branch as commit d9eae71 "style: add typing and remove noqas (#802)" for ticket CRAFT-4684, with all test and lint CI checks passing and 3 approving reviewers. Follow-up factory-function work to fully drop craft-application import ignores was discussed in review but not blocking this PR.

Evaluated by: mr-cal-bot

No scores available.

Issue body

CRAFT-4684 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #802 (commit d9eae71) added type hints and removed noqa comments across 61 files (+1220/-972) for CRAFT-4684; approved by 3 reviewers and merged after 7 review comments.
qwen/qwen3.6-35b-a3b — closed resolved Merged PR adding type hints and removing noqa comments across 61 files to address CRAFT-4684.

Update history

Date Change
created

Related issues

No related issues found above the similarity threshold.