← Back to issue list

feat(models): add SnapdResponse model for snapd Response

View original Github issue

Metadata

Project
craft-providers
Number
#939
Type
pull request
State
merged
Author
PraaneshSelvaraj
Labels
—
Created
Updated
Closed

Current evaluation

Merged #939 as 2702b5a, adding a Pydantic SnapdResponse model and tests to fix #784. The reported macOS CI failure was confirmed as unrelated flakiness.

Resolution: closed resolved

Reason: PR #939 merged into main as commit 2702b5a, introducing SnapdResponse validation and unit tests. A maintainer confirmed the remaining macOS failure was unrelated CI flakiness and a known multipass issue.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Converted SnapdResonpse into a pydantic model and added testcases. Fixes: #784 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #939 as 2702b5a, adding a Pydantic SnapdResponse model and tests to fix #784. The reported macOS CI failure was confirmed as unrelated flakiness.
stealth/space-bunny-alpha — closed resolved Merged in #939 via commit 2702b5a, adding a Pydantic SnapdResponse model and tests to fix #784. The reported macOS failure was unrelated CI flakiness.
qwen/qwen3.6-35b-a3b — — Merged. Implemented SnapdResponse as a Pydantic model with tests, fixing #784. Approved by two reviewers. A failing macOS CI test was unrelated flakiness; a re-run was scheduled to finalize the merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Implements SnapdResponse as a Pydantic model to resolve issue #784. Includes test cases and passes CI after maintainer addressed unrelated flakiness.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-providers#784 (confidence 100%)

    PR #939 explicitly fixes #784 by replacing loose snapd response data with a Pydantic model.

  • Related To: canonical/craft-providers#908 (confidence 95%)

    The preceding SnapInfo model work prepared the snapd response model introduced by #939.

Related issues

Issue Project State Summary Similarity
#908 feat(models): add SnapInfo model for snapd response craft-providers merged Merged PR #908 as commit e996996, adding a Pydantic SnapInfo model, optional publisher handling, and tests for snapd responses; fixes #783.
82%
#784 Snap revision should use a Pydantic model craft-providers closed Fixed by merged PR #908 (e996996), adding Pydantic SnapdResponse and SnapInfo models for validated snapd API responses.
76%