← Back to issue list

test: failing reproducer - no error for high UID (>65535)

View original Github issue

Metadata

Project
craft-providers
Number
#949
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds failing reproducer test test_set_id_map_raises_for_high_uid showing _set_id_map() lacks a uid>65535 check; the actual fix is described but NOT implemented. Red by design on 4 test-basic jobs, 0 reviews, idle 163 days.

Suggested action: keep open

Reason: This is an incomplete work-in-progress reproducer: the diff is +27/-0 in one test file and CI is intentionally red on 4 test-basic / Fast tests jobs because the fix described in the body (a uid > 65535 ProviderError check in _set_id_map()) was never added — grepping the repo for 65535 returns no matches and launcher.py:534 still calls lxc.config_set unconditionally. Merging as-is would break main, so it is not ready for review or merge; with 0 comments and no reviewer activity for 163 days it is a maintainer-authored WIP that should be finished (add the guard plus the test) rather than reviewed or closed.

Evaluated by: mr-cal-bot

Impact: 30 Quick Win: 7 Complexity: 12 Confidence: 84 Actionability: 25

Issue body

## Reproducer for #259 Enterprise systems using NIS, SSSD, or Active Directory commonly assign UIDs above 65535. When `map_user_uid=True` with such a UID, LXD rejects it with: ``` Error: Failed instance creation: Failed creating instance record: Failed initialising instance: Host id is in the range of subids ``` This message is cryptic. craft-providers should detect this condition and raise a clear `ProviderError` **before** calling LXD. ### Failing test `test_set_id_map_raises_for_high_uid` — shows that `_set_id_map()` currently calls `lxc.config_set(raw.idmap=...)` for UIDs > 65535 rather than raising a descriptive error first. ### Fix Add a check in `_set_id_map()` before the `lxc.config_set` call: if `uid > 65535`, raise a `ProviderError` with a link to documentation. Closes #259

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 30
Quick Win: 7
Complexity: 12
Confidence: 84
Actionability: 25
keep open Adds failing reproducer test test_set_id_map_raises_for_high_uid showing _set_id_map() lacks a uid>65535 check; the actual fix is described but NOT implemented. Red by design on 4 test-basic jobs, 0 reviews, idle 163 days.
stealth/space-bunny-alpha
Impact: 12
Quick Win: 1
Complexity: 15
Confidence: 95
Actionability: 12
keep open Open, unreviewed test-only PR adds a reproducer for missing high-UID validation; no fix is included, and Fast/Minimum dependency checks fail.
stealth/space-bunny-alpha
Impact: 30
Quick Win: 14
Complexity: 8
Confidence: 92
Actionability: 50
needs review Adds a failing high-UID ID-map reproducer for #259, but intentionally omits the production validation. Fast Linux, macOS, and minimum-dependency suites fail on the new test; no reviewer feedback is recorded.
qwen3.6-35b-a3b-mtp-q6
Impact: 50
Quick Win: 40
Staleness: 70
Complexity: 20
Confidence: 70
needs review Failing test reproducer for craft-providers#259: _set_id_map() should raise ProviderError for UIDs >65535 before calling LXD. PR incomplete, no fix implemented.
qwen/qwen3.6-35b-a3b
Staleness: 65
Complexity: 10
Confidence: 75
needs review Adds a failing test reproducing LXD rejection for UIDs >65535 and proposes a check in _set_id_map() to raise a clear ProviderError before LXD invocation. Currently pending maintainer review with mixed CI results.
qwen3.6-35b-a3b-mtp-q6
Staleness: 55
Complexity: 20
Confidence: 85
needs review Adds a failing test reproducing a cryptic LXD error when using UIDs above 65535. Describes a fix to validate UIDs before LXD interaction. Currently inactive with no comments.

Update history

No update history recorded yet.

Related work

  • Related To: craft-providers#259 (confidence 90%)

    PR claims 'Closes #259', but that issue is still open; the 65535 diagnostic gap it describes is real but not closed by this PR since no fix is included.

  • Related To: canonical/craft-providers#780 (confidence 72%)

    Merged commit 5717e2c 'fix(lxd): set uid map and gid map separately' already improved high-UID idmap handling (closing #769); this PR only adds a clearer pre-flight error, which remains unimplemented.

Related issues

No related issues found above the similarity threshold.