← Back to issue list

test: failing reproducer - no warning for default compatibility tag

View original Github issue

Metadata

Project
craft-providers
Number
#950
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds a 21-line failing reproducer test (test_default_compat_tag_logs_warning) for issue #454: BuilddBase with the default compatibility tag logs no warning. No fix included; fast/min-deps CI red, unreviewed for 163 days.

Suggested action: keep open

Reason: The diff is test-only (+21/-0, 1 file) and intentionally red: 'Fast tests' and 'Minimum dependencies' jobs fail because test_default_compat_tag_logs_warning asserts a warning that BuilddBase.__init__ (craft_providers/bases/ubuntu.py:130-140) never emits — grepping HEAD for that test name returns no matches, confirming the fix is absent. Merging would break the main branch, but the reproducer is still relevant (issue #454 remains open and no superseding commit exists), so it should be kept open for the author to add the logger.warning described in the body rather than closed as obsolete.

Evaluated by: mr-cal-bot

Impact: 10 Quick Win: 3 Complexity: 8 Confidence: 82 Actionability: 28

Issue body

## Reproducer for #454 When two different applications create `BuilddBase` without a custom `compatibility_tag`, both receive the tag `"buildd-base-v7"`. The resulting base LXD instance gets the same name in every project, and LXD refuses to start the second one with: ``` Error: Failed start validation for device "eth0": Instance DNS name "base-instance-buildd-base-v3-..." already used on network ``` ### Failing test `test_default_compat_tag_logs_warning` — shows that constructing `BuilddBase` without a custom `compatibility_tag` does not emit any warning. ### Fix (quick) In `BuilddBase.__init__()`, when `compatibility_tag` is `None` (default), emit a `logger.warning` telling the developer to pass a custom tag to avoid conflicts. Closes #454

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 10
Quick Win: 3
Complexity: 8
Confidence: 82
Actionability: 28
keep open Adds a 21-line failing reproducer test (test_default_compat_tag_logs_warning) for issue #454: BuilddBase with the default compatibility tag logs no warning. No fix included; fast/min-deps CI red, unreviewed for 163 days.
stealth/space-bunny-alpha
Impact: 12
Quick Win: 3
Complexity: 6
Confidence: 86
Actionability: 25
keep open Adds a single intentionally failing unit test (21 lines) reproducing missing warning for default compatibility_tag in BuilddBase; the actual logger.warning fix is not included, so Fast/min-deps CI jobs are red. No reviews in 163 days.
stealth/space-bunny-alpha
Impact: 10
Quick Win: 2
Complexity: 12
Confidence: 96
Actionability: 20
keep open Adds a 21-line failing reproducer for #454: default BuilddBase tags can cause LXD DNS collisions without warning. The fix is absent; unreviewed for 155 days, with fast and minimum-dependency CI failing.
qwen3.6-35b-a3b-mtp-q6
Impact: 50
Quick Win: 40
Staleness: 75
Complexity: 20
Confidence: 65
needs review Adds a failing test reproducing issue #454: BuilddBase without custom compatibility_tag emits no warning, causing LXD DNS conflicts. Proposes adding a logger.warning in __init__.
qwen/qwen3.6-35b-a3b
Staleness: 60
Complexity: 10
Confidence: 85
needs review Adds a failing test reproducing a LXD instance name conflict when BuilddBase lacks a custom compatibility_tag. Currently awaiting review with some CI checks failing.
qwen3.6-35b-a3b-mtp-q6
Staleness: 65
Complexity: 15
Confidence: 85
needs review Adds a failing test and proposes a logger.warning fix in BuilddBase.__init__ to prevent LXD instance name collisions when compatibility_tag is omitted. Currently inactive for 79 days with no comments.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-providers#454 (confidence 95%)

    PR body states 'Reproducer for #454' and 'Closes #454'; the issue (default compatibility tag causes LXD DNS collisions) is still open, and the proposed fix there — a warning for now, required tag deferred to a major release — matches this PR's scope.

Related issues

No related issues found above the similarity threshold.