← Back to issue list

feat: add file based backend as a fallback

View original Github issue

Metadata

Project
craft-store
Number
#119
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #119 added a file-based keyring fallback for headless systems, fixing #109 and #58 in commit 60699d1.

Resolution: closed resolved

Reason: PR #119 was approved and merged, with its implementation committed as 60699d1. The PR explicitly states that it fixes issues #109 and #58.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Useful when a keyring is not available, such as when running on a headless system. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? ----- Fixes #109 #58

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #119 added a file-based keyring fallback for headless systems, fixing #109 and #58 in commit 60699d1.
stealth/space-bunny-alpha — closed resolved Merged PR #119 added a file-based backend as a keyring fallback for headless systems, fixing #109 and #58 in commit 60699d1.
stealth/space-bunny-alpha — closed resolved Merged PR #119 (commit 60699d1), adding a file-based backend fallback when no keyring is available and fixing #109 and #58.
qwen/qwen3.6-35b-a3b — — Merged changes adding a file-based backend as a fallback when keyrings are unavailable, resolving issues #109 and #58. Approved by two reviewers, passed CI, and modified four files with 235 additions and 63 deletions.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#236 feat: add opt-in fallback to FileKeyring craft-store merged Merged PR #236 in commit 241ade9, adding opt-in FileKeyring fallback when SecretService is unavailable for file-based secret storage.
77%
#109 File based backend craft-store closed File-backed credential storage was implemented as a keyring fallback in commit 60699d1; PR #236 later made the fallback opt-in.
76%