← Back to issue list

chore: migrate build from setup.cfg to pyproject.toml

View original Github issue

Metadata

Project
craft-store
Number
#120
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged craft-store#120 (commit ac0969d): moved packaging/build metadata from setup.cfg into pyproject.toml's PEP 621 [project] table, +18/-134 lines across setup.cfg and pyproject.toml; approved by 2 reviewers.

Resolution: closed resolved

Reason: The pull request itself was merged by maintainer lengau into main as commit ac0969d, carrying the setup.cfg metadata over into pyproject.toml. A follow-up commit ac1ff0a removed the now-empty setup.cfg, confirming the migration landed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged craft-store#120 (commit ac0969d): moved packaging/build metadata from setup.cfg into pyproject.toml's PEP 621 [project] table, +18/-134 lines across setup.cfg and pyproject.toml; approved by 2 reviewers.
stealth/space-bunny-alpha — closed resolved Merged craft-store#120: migrated build metadata from setup.cfg to pyproject.toml in commit ac0969d, reducing 134 lines to 18 across two files.
qwen/qwen3.6-35b-a3b — — Migrated build configuration from setup.cfg to pyproject.toml. Approved by two reviewers, passed CI checks, and merged. The update streamlined project metadata across two files, reducing configuration lines by 116.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-store@ac0969d (confidence 95%)

    Merge commit for PR #120 that relocated metadata from setup.cfg into pyproject.toml [project].

  • Related To: canonical/craft-store@ac1ff0a (confidence 90%)

    Follow-up commit 'chore: remove setup.cfg' deleting the file emptied by the migration.

  • Related To: canonical/craft-store@844195d (confidence 65%)

    Adjacent chore commit migrating pyright config into pyproject.toml, part of the same config-consolidation effort.

  • Related To: canonical/craft-store#94 (confidence 40%)

    Prior PR that edited setup.cfg (requests minimum version), the last change to the file before it was migrated away.

Related issues

Issue Project State Summary Similarity
#1422 chore: migrate setup.py to pyproject.toml charmcraft closed Closed unmerged after prolonged inactivity; the same setup.py-to-pyproject.toml migration was later merged in #1455 via commit f41e333d.
83%
#782 chore: replace setup.py with pyproject.toml craft-parts closed PR #782 (setup.py to pyproject.toml) was closed unmerged after ~2 years with no review. The same migration landed later via PR #902, commit 5a1a5db0 "build: migrate to pyproject.toml", which removed setup.py/setup.cfg.
82%
#751 chore: migrate setup.py to pyproject.toml rockcraft merged Merged PR #751 in commit bc45bedf, replacing setup.py and setup.cfg with pyproject.toml to support standalone Starflow workflows.
79%
#550 chore: move project configuration to pyproject.toml rockcraft closed Closed unmerged after prolonged inactivity; the configuration migration was later completed by merged PR #751 in commit bc45bedf.
79%
#293 ci: migrate setup.cfg to pyproject.toml craft-providers merged Merged PR #293 in commit 163c1d7, migrating packaging metadata from setup.cfg to pyproject.toml as part of #287 and building on PR #292.
79%
#740 build: replace setup.py and setup.cfg with pyproject.toml rockcraft closed Closed unmerged; its setup.py/setup.cfg-to-pyproject.toml migration was superseded by merged PR #751 in commit bc45bedf.
75%
#294 ci: migrate setup.py to pyproject.toml craft-providers merged Merged PR #294 in commit 1d4f8ba, completing the setup.py-to-pyproject.toml packaging migration after #293 and advancing #287.
74%
#1455 build: replace setup.py with pyproject.toml charmcraft merged Merged #1455 in commit f41e333d, replacing setup.py with pyproject.toml and moving packaging metadata and setuptools-scm version handling to the modern build configuration.
74%
#1631 chore(deps): update internal packages charmcraft merged Renovate PR merged as commit c26661a5: bumped craft-application 2.1.0->2.4.0, craft-grammar 1.1.2->1.2.0, craft-store 2.6.0->2.6.1 in pyproject.toml.
74%
#902 build: migrate to pyproject.toml craft-parts merged PR #902 merged as commit 5a1a5db0 ("build: migrate to pyproject.toml"), deleting setup.py/setup.cfg in favour of pyproject.toml as a prerequisite for the Starflow workflow migration.
73%