← Back to issue list

feat: add publisher gateway client

View original Github issue

Metadata

Project
craft-store
Number
#240
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit c0cd369, adding a basic craft_store.publisher.PublisherGateway client (with Ubuntu One SSO login) for Charmcraft's create-track command (CRAFT-3424); implements craft-store#239.

Resolution: closed resolved

Reason: The PR was approved by 3 reviewers and merged into main as commit c0cd369, landing the new craft_store/publisher package (_publishergw.py, _request.py, _response.py) exported as PublisherGateway, which is the client requested by craft-store#239. Follow-up PR #281 (commit 30721da) later improved PublisherGateway error details.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This adds a very basic publisher gateway client that meets the needs of charmcraft's new 'create-track' command. The client cannot login yet and still depends on the old requests-based clients for many features. Potentially resolves #239 CRAFT-3424 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit c0cd369, adding a basic craft_store.publisher.PublisherGateway client (with Ubuntu One SSO login) for Charmcraft's create-track command (CRAFT-3424); implements craft-store#239.
stealth/space-bunny-alpha — closed resolved Merged the basic publisher gateway client for Charmcraft’s create-track command (CRAFT-3424). It cannot log in yet and still relies on legacy requests-based clients.
qwen/qwen3.6-35b-a3b — — Merged following three approvals and passing CI. Adds a basic publisher gateway client for charmcraft's create-track command across 18 files (+651/-56). Suggested changelog update. Resolves #239 and CRAFT-3424.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: canonical/craft-store#239 (confidence 95%)

    The linked issue 'create a client for the publisher gateway', which the PR states it potentially resolves.

  • Related To: canonical/craft-store#281 (confidence 70%)

    Follow-up commit 30721da 'feat(PublisherGW): better error details' extending the same client.

Related issues

Issue Project State Summary Similarity
#369 feat(login): Add PublisherGateway login with Ubuntu One SSO craft-store merged Merged into main as commit d4e9806 (merge commit ccc3163), adding craft-parts login support for PublisherGateway with Ubuntu One SSO (+1516/-7, 16 files).
80%
#249 feat(publishergateway): implement more endpoints craft-store merged Merged into main as 4ebf989, adding PublisherGateway endpoints; shipped in craft-store 3.2.0. Follow-up lint cleanup landed in #255 as 11c4c21.
76%
#2024 feat: create-track command charmcraft merged Merged the create-track command in canonical/charmcraft#2024 via commit 7615a1c1, using publisher-gateway support from canonical/craft-store#240.
75%