← Back to issue list

Rework the API to remove repetitiveness and redundancy

View original Github issue

Metadata

Project
craft-store
Number
#244
Type
issue
State
open
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

API rework to expose craft_store.models.Account and craft_store.PublisherGateway, removing model redundancy. PublisherGateway is now top-level, but models still export AccountModel and duplicates remain; no labels or activity since the 2024 Jira ticket.

Suggested action: needs triage

Reason: The issue has no labels, no assignee, and no maintainer response beyond the Jira bot's 2024-12-13 comment (CRAFT-3812), so it has never been categorised or prioritised. It is still partially valid — craft_store.PublisherGateway now exists (PR #240), but craft_store.models still exports AccountModel rather than Account and the models/publisher packages still duplicate definitions — so closing it as stale would be premature.

Impact: 40 Quick Win: 12.0 Staleness: 75 Complexity: 70 Confidence: 78 Support Request: 0

Issue body

### What needs to get done The API should look more like: - `craft_store.models.Account` - `craft_store.PublisherGateway` ### Why it needs to get done https://benhoyt.com/writings/python-api-design/

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 40
Quick Win: 12.0
Staleness: 75
Complexity: 70
Confidence: 78
Support Request: 0
needs triage API rework to expose craft_store.models.Account and craft_store.PublisherGateway, removing model redundancy. PublisherGateway is now top-level, but models still export AccountModel and duplicates remain; no labels or activity since the 2024 Jira ticket.
qwen/qwen3.6-35b-a3b
Staleness: 90
Complexity: 75
Confidence: 85
Support Request: 10
close stale Request to refactor the API structure for reduced redundancy, referencing Python API design best practices. Currently unlabelled and inactive for over a year with no maintainer follow-up.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 45
Confidence: 65
Support Request: 10
needs triage Unassessed feature request proposing an API rework to reduce redundancy. Open for over a year with no maintainer response, labels, or assignee, requiring prioritization and scoping.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 60
Confidence: 70
Support Request: 5
needs triage Proposes restructuring the API to eliminate redundancy with a cleaner module and class layout. Acknowledged with an internal ticket. Inactive for over a year, currently needs triage and assignment to advance the design improvements.

Update history

No update history recorded yet.

Related work

  • Related To: craft-store#240 (confidence 75%)

    PR #240 added the top-level craft_store.PublisherGateway, delivering one of the two API shapes requested; the models.Account rename and redundancy removal remain outstanding.

Related issues

No related issues found above the similarity threshold.