← Back to issue list

feat: don't use error list as details

View original Github issue

Metadata

Project
craft-store
Number
#295
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged a fix preventing duplicate error messages in CraftStoreErrors. A craft-cli update started displaying error details by default, causing redundant output. The change modifies logging to use the error list instead, resolving the duplication across two files.

Suggested action:

No scores available.

Issue body

A recent-ish change in craft-cli made an error's 'details' get shown to the user by default. This means that CraftStoreErrors with a single store error would get the actual error message printed twice - once from the 'brief' and once from the 'details'. Instead, log the error list (as it has relevant error codes). - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix preventing duplicate error messages in CraftStoreErrors. A craft-cli update started displaying error details by default, causing redundant output. The change modifies logging to use the error list instead, resolving the duplication across two files.
qwen3.6-35b-a3b-mtp-q6 Merged a fix preventing duplicate error messages from a craft-cli update. The change logs the error list directly instead of using it as error details, ensuring relevant error codes appear only once.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#591 Revisited all error usage to adapt to new craft-cli context. charmcraft merged Merged after approval and CI. Updated error handling for craft-cli by using from err for subprocess errors, adding details attributes, adjusting Store return codes, and transforming StoreServerError. Changed 8 files.
73%