← Back to issue list

ci: delete duplicate workflow

View original Github issue

Metadata

Project
craft-store
Number
#357
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

PR #357 merged (commit 43767c0) removing .github/workflows/security-scan.yaml, added earlier in #218, as duplicate; the "Security scan" python-scans job already runs in policy.yaml via canonical/starflow.

Resolution: closed resolved

Reason: The pull request was merged into main as commit 43767c0, deleting the redundant security-scan workflow file. The file history shows it was only ever introduced by #218 and removed here, confirming the intent was CI cleanup with security scanning retained via the policy.yaml python-scans job.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? ----- We already do a security scan in [policy.yaml](https://github.com/canonical/craft-store/blob/e279c879db7924f332f77797b34a2cf5fc6d5f01/.github/workflows/policy.yaml)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #357 merged (commit 43767c0) removing .github/workflows/security-scan.yaml, added earlier in #218, as duplicate; the "Security scan" python-scans job already runs in policy.yaml via canonical/starflow.
stealth/space-bunny-alpha — closed resolved PR #357 merged as commit 43767c0, deleting the duplicate security-scan.yaml workflow (added in #218) since security scanning already runs in policy.yaml.
stealth/space-bunny-alpha — closed resolved Merged PR #357 (commit 43767c0) removed a duplicate security-scan workflow because scanning already runs in policy.yaml.
qwen/qwen3.6-35b-a3b — — Merged to remove a duplicate CI workflow. Security scanning was already configured in policy.yaml, rendering the workflow redundant. Approved by two reviewers with all CI checks passing, the change deleted 13 lines in one file.

Update history

No update history recorded yet.

Related work

  • Caused By: canonical/craft-store#218 (confidence 70%)

    Commit db9a779 'ci: add security scan workflow (#218)' created the workflow that this PR deleted as duplicate.

  • Duplicate Of: starflow#416 (confidence 25%)

    Not a real reference — the scan job is provided by canonical/starflow's scan-python.yaml invoked from policy.yaml, which is where scanning continues to live after this PR.

Related issues

Issue Project State Summary Similarity
#666 ci: add security scan workflow craft-providers merged Merged PR #666 added a CI security-scan workflow; merge commit b1abe71 records the change.
72%
#56 ci: add security scanning workflow craft-grammar merged Merged security-scanning CI workflow via PR #56, recorded in commit a6f1a1d.
72%
#3 feat: Python project scan reusable workflow starflow merged Merged the reusable Python project security-scan workflow in canonical/starflow#3 at commit 41c1942, adding 231 lines across two files.
72%
#716 ci: add security scan workflow rockcraft merged Merged PR #716 added the security-scan workflow; commit 94b6877e records the change in the repository history.
71%
#1924 ci: add security scan workflow charmcraft merged Merged #1924 in commit 5634ecb1, adding the CI security-scan workflow after syncing canonical/craft-archives#128; two reviewers approved it.
70%
#218 ci: add security scan workflow craft-store merged Merged PR #218 via commit db9a779, adding a 13-line GitHub Actions security-scan workflow after two approvals; no CI checks were reported.
70%