← Back to issue list

auth: do not allow overwriting existing credentials (CRAFT-776)

View original Github issue

Metadata

Project
craft-store
Number
#39
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Prevents overwriting existing credentials in the authentication module. Merged following approval and passing CI checks, updating eight files with 72 additions and 18 deletions. Resolves CRAFT-776.

Suggested action:

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Prevents overwriting existing credentials in the authentication module. Merged following approval and passing CI checks, updating eight files with 72 additions and 18 deletions. Resolves CRAFT-776.
qwen3.6-35b-a3b-mtp-q6 Merged to prevent overwriting existing credentials in the auth module, resolving CRAFT-776. The change was integrated directly after CLA verification, with no additional review comments required.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5 auth: new module to handle credentials (CRAFT-492) craft-store merged Merged a new auth module wrapping the system keyring to handle credentials. Approved by two reviewers, the change introduces 363 lines across 10 files and resolves CRAFT-492.
78%
#53 auth: allow for ephemeral logins craft-store merged Ephemeral login support was merged after approval and passing CI checks. The update added 49 lines and removed 20 across six files, implementing CRAFT-1025.
74%
#45 auth: raise error when credentials cannot be parsed (CRAFT-812) craft-store merged Merged changes to craft-store that replace cryptic base64 decoding errors with a clear CredentialsNotParseable exception for invalid credentials. Approved by one reviewer and passed CI.
72%
#40 auth: rename validate_set_credentials to ensure_no_credentials craft-store merged Renamed the auth function validate_set_credentials to ensure_no_credentials to better convey its purpose. The update was approved, passed CI, and merged, modifying four files with a ten-line diff.
71%