← Back to issue list

feat: add constants for more known attenuations

View original Github issue

Metadata

Project
craft-store
Number
#399
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #399 by maintainer lengau added constants for more known permission values, replaced magic strings with them, and fixed issue #386. Merged with 2 approvals; only the OSV-scanner check failed.

Resolution: closed resolved

Reason: The PR itself was merged into craft-store's main branch and explicitly states "Fixes #386" (CRAFT-5221). Issue #386 was subsequently closed as resolved, with commit 19166ba adding the permission constants and replacing the magic strings.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Also uses those constants instead of magic strings. Fixes #386 CRAFT-5221 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/craft-store/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #399 by maintainer lengau added constants for more known permission values, replaced magic strings with them, and fixed issue #386. Merged with 2 approvals; only the OSV-scanner check failed.
stealth/space-bunny-alpha — closed resolved Merged PR #399 added constants for known attenuations, replaced magic strings, and fixed #386.
qwen/qwen3.6-35b-a3b — — Merged pull request adding constants for known attenuations and replacing magic strings. Approved by two reviewers and passed CI checks. Resolves issue #386 and addresses CRAFT-5221.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-store#386 (confidence 97%)

    PR body declares 'Fixes #386'; that issue is closed, resolved by this PR (commit 19166ba).

  • Related To: canonical/craft-store#386 (confidence 90%)

    Same tracker area: constants for common permissions/attenuation values replacing magic strings.

Related issues

Issue Project State Summary Similarity
#386 Create constants for common permissions values craft-store closed Permission constants were added and magic strings replaced by merged PR #399 (commit 19166ba), resolving #386.
72%