store client: use netloc to reference keyring location (CRAFT-799)
Metadata
Current evaluation
Merged in craft-store#44 via 28dc11b (implementation 12b7ead): the store client now uses URL netloc for keyring locations and passes it to Auth, potentially invalidating old logins.
Resolution: closed resolved
Reason: PR #44 was approved and merged. Commit 12b7ead removed the unused host attribute and changed keyring lookup to use the base URL's netloc.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This was somehow missed, as seen from the unsused attribute which is now removed
and processed when passing the "host" parameter to Auth.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
This does have the drawback of forgetting of forgetting about existing logins.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in craft-store#44 via 28dc11b (implementation 12b7ead): the store client now uses URL netloc for keyring locations and passes it to Auth, potentially invalidating old logins. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged store-client change to use netloc for the keyring location, remove the unused host attribute, and pass netloc to Auth. Existing logins at the old location are forgotten. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update to store client using netloc for keyring location references and passing the host parameter to Auth. Removed unused attribute. Existing logins are forgotten as a known side effect. Approved by two reviewers and passed CI. |
Update history
No update history recorded yet.
Related issues
No related issues found above the similarity threshold.