← Back to issue list

store client: use netloc to reference keyring location (CRAFT-799)

View original Github issue

Metadata

Project
craft-store
Number
#44
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged update to store client using netloc for keyring location references and passing the host parameter to Auth. Removed unused attribute. Existing logins are forgotten as a known side effect. Approved by two reviewers and passed CI.

Suggested action: —

No scores available.

Issue body

This was somehow missed, as seen from the unsused attribute which is now removed and processed when passing the "host" parameter to Auth. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This does have the drawback of forgetting of forgetting about existing logins.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged update to store client using netloc for keyring location references and passing the host parameter to Auth. Removed unused attribute. Existing logins are forgotten as a known side effect. Approved by two reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged change to store client using netloc for keyring location references. Removes unused attribute and passes host to Auth. Resolves CRAFT-799 but causes existing logins to be forgotten.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#38 auth: avoid MemoryKeyring in keyring and raise appropriately (CRAFT-771) craft-store merged Addressed CRAFT-771 by modifying StoreClient to raise an exception during initialization if no keyring is found, avoiding MemoryKeyring. Approved, passed CI, and merged.
73%
#667 craft store: update to 2.0.0 (CRAFT-773) charmcraft merged Merged craft store update to 2.0.0. Changes include updated StoreClient initialization, renaming NotLoggedIn to CredentialsUnavailable, improved keyring handling, and adjusted relogin logic. Approved by one reviewer, passed CI, and merged by maintainer sergiusens.
70%