← Back to issue list

auth: update stored authentication format

View original Github issue

Metadata

Project
craft-store
Number
#70
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged in craft-store#70 (commit 3a95724), changing stored credentials to JSON type/value records while retaining backward compatibility for legacy authentication payloads.

Resolution: closed resolved

Reason: The approved PR was merged as commit 3a95724. It introduced explicit token types in the stored JSON format and retained support for reading previously stored credentials.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Instead of storing a payload that depends on the auth 'flavor' (Candid or UbuntuOne), store, as a JSON string, a dict containing the token "type" t and the actual payload value v. Add some backwards-compatibility support to allow reading credentials stored in the previous (type-dependent) way. Tagging the token type allows us to extend supported types in the future. CRAFT-1327

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in craft-store#70 (commit 3a95724), changing stored credentials to JSON type/value records while retaining backward compatibility for legacy authentication payloads.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-store#70 (commit 3a95724), updating stored auth to JSON type/value records while retaining backward compatibility for legacy credentials.
qwen/qwen3.6-35b-a3b — — Merged an update to the authentication storage format, replacing flavor-dependent payloads with a JSON dict containing token type and value. Includes backwards compatibility for legacy credentials. Approved and merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#45 auth: raise error when credentials cannot be parsed (CRAFT-812) craft-store merged Merged in canonical/craft-store#45 (commit f985651), replacing raw base64 decoding errors with CredentialsNotParseable; shipped in craft-store 2.0.1.
72%