← Back to issue list

Fix integration test fixtures broken by craft-application dependency update

View original Github issue

Metadata

Project
debcraft
Number
#118
Type
pull request
State
merged
Author
Copilot
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #118 updated integration fixtures for craft-application's new validation format and required summary and description fields; Canonical CLA passed.

Resolution: closed resolved

Reason: PR #118 was merged and fixed the broken fixtures by adding the invalid input value to the expected error and supplying newly required project fields. Its only reported CI check, Canonical CLA, passed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Lock file maintenance updated `craft-application`, which changed validation error message format (now includes `input` field) and added required fields to project models. ## Changes - **`tests/integration/project/invalid-projects/invalid-name/error-message.txt`**: Updated expected error to match new format including the invalid input value: ``` - ... (in field 'name', input: '-a-') ``` - **`tests/integration/project/valid-projects/minimal/debcraft.yaml`**: Added `summary` and `description`, now mandatory fields: ```yaml name: debcraft-minimal summary: A minimal debcraft project description: A minimal debcraft project for testing purposes ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #118 updated integration fixtures for craft-application's new validation format and required summary and description fields; Canonical CLA passed.
stealth/space-bunny-alpha — closed resolved Merged PR #118 updated integration fixtures for the craft-application update, adding invalid-input error details and required summary and description fields.
stealth/space-bunny-alpha — closed resolved Merged PR #118 fixed integration test fixtures after a craft-application update, aligning validation-error expectations and adding required project fields; Canonical CLA passed.
qwen/qwen3.6-35b-a3b — — Merged fix for integration test fixtures broken by a craft-application dependency update. Updated expected validation error messages to include the input field and added mandatory summary and description fields to test project models. CI passed.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for integration test fixtures broken by a craft-application dependency update. Updated validation error expectations to include the input field and added mandatory summary and description fields to test fixtures.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#65 Fix test failures from dependency updates in lock file maintenance debcraft merged Merged PR #65, updating tests for craft-application validation changes by adding input to the invalid-name expectation and summary/description to the minimal fixture.
81%
#1454 build: update craft-application charmcraft merged Merged in commit 952f070e, updating craft-application and adjusting affected test constants.
72%
#131 build: separate unit and integration tests in CI craft-application merged Merged CI change separating unit and integration tests in canonical/craft-application#131 (commit 3a4a2b64).
71%
#6 base: craft-application prototype craft-application merged Merged the initial craft-application prototype in canonical/craft-application#6, changing 21 files (+1029/-204); fuller tests were deferred to a follow-up PR.
70%