← Back to issue list

feat(installdebconf): token substitution

View original Github issue

Metadata

Project
debcraft
Number
#162
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged an update implementing token substitution for template config files in dh_installdebconf. Approved, passed CI, and closed issue 159. The change adds 216 lines across 5 files to enable environment variable lookup.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Implements token substitution for special template config files. Some notes for reviewers: - The "ENV." prefix means that the value should be looked up from the current environment. - It seems like `${...}` is a more common delimiter than `#...#`, but this PR only focuses on working with `dh_installdebconf`'s behaviors, which opt for `#...#` instead. This work shouldn't be terribly difficult to refactor to work with either delimiter style in the future. - This does not implement per-package values (e.g. `pkg.foo.CUSTOM_KEY`, `pkg.bar.CUSTOM_KEY`), as those are only set via the CLI for debhelpers normally and such inputs are not yet supported. Closes #159 DEBCRAFT-71

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged an update implementing token substitution for template config files in dh_installdebconf. Approved, passed CI, and closed issue 159. The change adds 216 lines across 5 files to enable environment variable lookup.
qwen3.6-35b-a3b-mtp-q6 Merged implementation of token substitution for dh_installdebconf template config files. Utilizes #...# delimiters and ENV. prefix for environment variable resolution. Closes #159 and resolves DEBCRAFT-71.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#156 feat: add installdebconf helper debcraft merged Merged after approval. Adds an installdebconf helper to copy debconf config and templates to the package control directory. Core functionality implemented while deferring token replacement and cleanup to future updates. CI checks passed.
74%
#159 Implement token substitution in debconf files debcraft closed Closed and superseded by Jira ticket DEBCRAFT-71. Token substitution for debconf files was not implemented. The request was abandoned in this repository.
72%