← Back to issue list

feat(installdebconf): token substitution

View original Github issue

Metadata

Project
debcraft
Number
#162
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #162 via commit d3b754c, adding token substitution for dh_installdebconf template config files and closing #159.

Resolution: closed resolved

Reason: PR #162 was approved and merged as commit d3b754c. It implements ENV.-prefixed environment token substitution, with per-package token values left unsupported.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Implements token substitution for special template config files. Some notes for reviewers: - The "ENV." prefix means that the value should be looked up from the current environment. - It seems like `${...}` is a more common delimiter than `#...#`, but this PR only focuses on working with `dh_installdebconf`'s behaviors, which opt for `#...#` instead. This work shouldn't be terribly difficult to refactor to work with either delimiter style in the future. - This does not implement per-package values (e.g. `pkg.foo.CUSTOM_KEY`, `pkg.bar.CUSTOM_KEY`), as those are only set via the CLI for debhelpers normally and such inputs are not yet supported. Closes #159 DEBCRAFT-71

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #162 via commit d3b754c, adding token substitution for dh_installdebconf template config files and closing #159.
stealth/space-bunny-alpha — closed resolved Merged canonical/debcraft#162, adding ENV-prefixed and #...# token substitution for dh_installdebconf template files and closing issue #159.
qwen/qwen3.6-35b-a3b — — Merged an update implementing token substitution for template config files in dh_installdebconf. Approved, passed CI, and closed issue 159. The change adds 216 lines across 5 files to enable environment variable lookup.
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation of token substitution for dh_installdebconf template config files. Utilizes #...# delimiters and ENV. prefix for environment variable resolution. Closes #159 and resolves DEBCRAFT-71.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/debcraft#159 (confidence 100%)

    The PR explicitly closes #159 with the token-substitution implementation.

Related issues

Issue Project State Summary Similarity
#159 Implement token substitution in debconf files debcraft closed Token substitution for dh_installdebconf files was merged in canonical/debcraft#162 (commit d3b754c), covering architecture, environment, and package tokens.
82%