fix(makeshlibs): don't always add revision to shlib versions
Metadata
Current evaluation
Merged PR canonical/debcraft#173 (commit 4087480) by maintainer bepri adds _get_shlibs_friendly_version, so makeshlibs no longer always appends the Debian revision to shlib versions, per Policy 8.6.4. Fixes #150, DEBCRAFT-76.
Resolution: closed resolved
Reason: The PR was merged into main as commit 4087480 after approval by 2 reviewers, with all test/lint CI checks passing. It implements the Policy 8.6.4 logic for shlib versioning and closes issue #150 (DEBCRAFT-76); +60/-6 lines across 2 files.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
---
Implements some logic from Debian Policy 8.6.4. See the docstring in the new `_get_shlibs_friendly_version` for a summary.
Fixes #150.
DEBCRAFT-76
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/debcraft#173 (commit 4087480) by maintainer bepri adds _get_shlibs_friendly_version, so makeshlibs no longer always appends the Debian revision to shlib versions, per Policy 8.6.4. Fixes #150, DEBCRAFT-76. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/debcraft#173 via commit 4087480, fixing shared-library versioning so revisions are not always added. Resolves #150 and DEBCRAFT-76. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix to shared library versioning that implements Debian Policy 8.6.4, preventing unnecessary revision additions. Resolves issue #150 and DEBCRAFT-76. Approved by reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
0
Complexity:
20
Confidence:
90
|
needs review | Updates makeshlibs to conditionally add revisions to shared library versions per Debian Policy 8.6.4. Fixes #150. PR is fresh, passes lint/test, and awaits maintainer review. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/debcraft#150
(confidence 98%)
Bug report '[Bug] makeshlibs generate shdeps with wrong version' was closed by this PR; its record cites the same commit 4087480.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #150 [Bug] makeshlibs generate shdeps with wrong version | debcraft | closed | Fixed by canonical/debcraft#173, merged as commit 4087480, which stops makeshlibs from always adding the Debian revision to shared-library versions. | |
| #104 feat: add symbols-based shlib dependencies | debcraft | merged | Merged in debcraft#104 via commit c70ce26, adding symbol-verified minimum-version dependencies from Debian .symbols files while retaining .shlibs support. |