← Back to issue list

test: unit tests for get_package and get_partitions methods

View original Github issue

Metadata

Project
debcraft
Number
#56
Type
pull request
State
open
Author
Copilot
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds unit tests for Project.get_package() and PackagesProject.get_partitions() as follow-up to merged #54. Pending rebase onto main requested by a maintainer; the Copilot bot can't force-push, and no activity for about 9 months.

Suggested action: needs review

Reason: Maintainer lengau asked on 2025-12-06 to rebase the branch on main, and the Copilot bot replied it lacks force-push access and asked a human to rebase; nothing has happened since (last activity 268 days ago). The tests remain relevant because #54, which added get_package/get_partitions, is merged, so a maintainer should rebase and push (or close and have the bot open a fresh branch) rather than let it rot. The large +578/-108 diff across 21 files for a test-only PR suggests the branch predates #54 and will shrink substantially after rebasing.

Impact: 25 Quick Win: 16.25 Staleness: 62 Complexity: 35 Confidence: 65

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Addresses review feedback from #54 requesting unit test coverage for the new `get_package` and `get_partitions` methods in project models. ### Changes - Added tests for `Project.get_package()`: - Successful package retrieval - Error when no packages defined - Error when package not found - Added tests for `PackagesProject.get_partitions()`: - Returns `["default"]` when no packages defined - Returns `["default", "package/<name>", ...]` when packages defined ```python def test_get_package_success(default_project): package = default_project.get_package("package-1") assert package.version == "2.0" def test_get_partitions_with_packages(): packages_project = project.PackagesProject( packages={"pkg-a": Package(version="1.0"), "pkg-b": Package(version="2.0")} ) result = packages_project.get_partitions() assert result == ["default", "package/pkg-a", "package/pkg-b"] ``` <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 25
Quick Win: 16.25
Staleness: 62
Complexity: 35
Confidence: 65
needs review Adds unit tests for Project.get_package() and PackagesProject.get_partitions() as follow-up to merged #54. Pending rebase onto main requested by a maintainer; the Copilot bot can't force-push, and no activity for about 9 months.
qwen/qwen3.6-35b-a3b
Staleness: 90
Complexity: 15
Confidence: 85
close stale Adds unit tests for get_package and get_partitions methods. Blocked on a maintainer-requested rebase that the AI author stated it cannot perform. Inactive for over 7 months with no follow-up.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 15
Confidence: 85
close stale Adds unit tests for get_package and get_partitions methods. Inactive for 7 months after maintainer requested a rebase that the AI author could not perform.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 10
Confidence: 75
close stale Adds unit tests for get_package and get_partitions methods in project models, covering success and error scenarios. The request is stalled and requires a maintainer to manually rebase it onto main before merging.

Update history

No update history recorded yet.

Related work

  • Related To: debcraft#54 (confidence 90%)

    This PR adds the unit tests requested in review feedback on #54; cmatsuoka said it could land on main after #54, which has since been merged.

Related issues

No related issues found above the similarity threshold.