← Back to issue list

Regression: fetch-service log no longer communicates that a port is already taken

View original Github issue

Metadata

Project
fetch-service
Number
#208
Type
issue
State
closed
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Closed without a code change: maintainers determined the fatal control-port exit was necessary; proxy-port conflicts still emit the expected bind error.

Resolution: closed not a bug

Reason: Maintainer cmatsuoka concluded that the fatal control-port exit was necessary, and tigarmo confirmed the regression only affected the control port. No resolving PR or commit was identified.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### Bug Description If the control or proxy ports are already occupied, the fetch-service exits immediately with code 0, with no indication of the issue. ### To Reproduce First I put up a Python process to use port 13555: ```python import socket s = socket.create_server(("localhost", 13555), reuse_port=True) ``` Then I ran this: ``` /snap/bin/fetch-service --control-port=13555 --proxy-port=13444 --config=/home/tiago/snap/fetch-service/common/test/config --spool=/home/tiago/snap/fetch-service/common/test/spool --cert=/home/tiago/snap/fetch-service/common/test-craft-app/fetch-certificate/local-ca.pem --key=/home/tiago/snap/fetch-service/common/test-craft-app/fetch-certificate/local-ca.key.pem --permissive-mode --idle-shutdown=300 ``` Notice on the log how the service exits immediately; the exit code is 0. The log used to say `bind: address already in use`. ### Relevant log output ```shell 2024/09/09 09:20:20.866089 INFO : Version 0.1.4-67-gad9869e 2024/09/09 09:20:20.866103 INFO : Loading certificate from /home/tiago/snap/fetch-service/common/test-craft-app/fetch-certificate/local-ca.pem 2024/09/09 09:20:20.866306 INFO : Loading key from /home/tiago/snap/fetch-service/common/test-craft-app/fetch-certificate/local-ca.key.pem 2024/09/09 09:20:20.866472 INFO : create CA from PEM certificate and key blocks 2024/09/09 09:20:20.866823 INFO : ACL configuration file /home/tiago/snap/fetch-service/common/test/config/acl.yaml does not exist 2024/09/09 09:20:20.866826 INFO : Starting service... 2024/09/09 09:20:20.866947 INFO : Starting the HTTP proxy; listening on :13444 2024/09/09 09:20:20.866966 INFO : Listening on configuration socket... 2024/09/09 09:20:20.867075 INFO : control server listening on :13555 2024/09/09 09:20:20.869000 INFO : Server exiting! 2024/09/09 09:20:20.869008 INFO : Stopping service... 2024/09/09 09:20:20.869011 INFO : [session] all sessions finished 2024/09/09 09:20:20.869012 INFO : Shutting down the HTTP proxy... 2024/09/09 09:20:20.869043 INFO : Shutting down configuration socket... 2024/09/09 09:20:20.869063 INFO : Shutting down the control API server... ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed not a bug Closed without a code change: maintainers determined the fatal control-port exit was necessary; proxy-port conflicts still emit the expected bind error.
stealth/space-bunny-alpha — closed not a bug Closed without a code change: maintainers determined the fatal control-port exit was necessary, while proxy-port conflicts still produce the expected bind error.
qwen/qwen3.6-35b-a3b — — Closed without code changes. Investigation determined the fatal exit is necessary, and the regression only impacts the control port while the proxy port continues logging correctly.

Update history

Date Change
created

Related issues

No related issues found above the similarity threshold.