← Back to issue list

fix: remove inspecting text/html in sourcecraft inspector

View original Github issue

Metadata

Project
fetch-service
Number
#229
Type
pull request
State
merged
Author
dariuszd21
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #229 fixed accidental Sourcecraft inspection of HTML by removing text/html inspection; released in v0.2.1 via commit aaa40a4.

Resolution: closed resolved

Reason: Commit aaa40a4 merged the fix and closed #228. The change prevents the Sourcecraft inspector from running on non-git HTML requests and is documented in the v0.2.1 changelog.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? It fixes the issue, when `sourcecraft` inspector runs accidentally on non-git requests Closes: #228

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #229 fixed accidental Sourcecraft inspection of HTML by removing text/html inspection; released in v0.2.1 via commit aaa40a4.
stealth/space-bunny-alpha — closed resolved Merged PR canonical/fetch-service#229 as aaa40a4, removing text/html inspection so the Sourcecraft inspector no longer runs on non-git requests.
qwen/qwen3.6-35b-a3b — — Merged to resolve issue #228 by removing text/html inspection in the sourcecraft inspector, preventing accidental processing of non-git requests. Approved by two reviewers and passed CI checks.

Update history

Date Change
created

Related work

Related issues

Issue Project State Summary Similarity
#228 Sourcecraft inspector is too restrictive fetch-service closed Fixed by merged PR #229 (commit aaa40a4): Sourcecraft no longer inspects HTML responses, preventing unrelated permissive-mode artifacts from being rejected.
79%
#230 release 0.2.1 fetch-service merged Release PR #230 merged and cut fetch-service 0.2.1 (2024-09-25), shipping the Sourcecraft inspector fix from #229. Changelog entry: 'fix: remove inspecting text/html in sourcecraft inspector (#229)'. Zero-diff release-only PR.
76%
#219 docs: document sourcecraft inspector fetch-service merged Merged PR #219 (commit f4a5dac) by dariuszd21 added docs/reference/sourcecraft.rst documenting the Sourcecraft inspector added in #217, closing CRAFT-3337. File later revised by #604.
72%