← Back to issue list

fix: don't fail parsing if line has no ':'

View original Github issue

Metadata

Project
fetch-service
Number
#243
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for parser failures on multi-line fields lacking colons. Refactored parsing to ignore colonless lines, skipping unneeded extra fields. Approved by two reviewers, passed CI, and resolves #240.

Suggested action:

No scores available.

Issue body

The first commit is a bit of refactoring to split out the code that does the parsing and make it easier to test; the second commit has the actual fix. ---- This apparently doesn't happen for the standard fields but "extra" fields like `Python-Version` and `X-Cargo-Built-Using` can actually be split over two lines. Since we don't read/need that information, just ignore it and keep parsing. Fixes #240

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for parser failures on multi-line fields lacking colons. Refactored parsing to ignore colonless lines, skipping unneeded extra fields. Approved by two reviewers, passed CI, and resolves #240.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#270 fix: correctly print multi-line errors craft-cli merged Merged fix for multi-line error printing. The change splits error strings to print each line individually, preventing leftover characters from previous progress messages. Approved by two reviewers, passed CI, and resolves #263.
70%