← Back to issue list

refactor: only unpack git repos once

View original Github issue

Metadata

Project
fetch-service
Number
#290
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR fetch-service#290 as commit 2ca0dfe, centralizing Git validation and checkout reuse; fixes fetch-service#276.

Resolution: closed resolved

Reason: Commit 2ca0dfe merged the refactor that validates, unpacks, and checks out Git repositories once in a session-local cache, resolving fetch-service#276.

Evaluated by: mr-cal-bot

No scores available.

Issue body

With this change, the git.upload-pack inspector becomes in charge of doing all git-related verifications (whether the fetch is shallow, single ref only, etc) and unpacks & checks out the wanted ref into a session-local directory that persists after the inspector is done. Other git-related inspectors can then use the new 'git-checkout-pack' annotation to directly inspect the contents of the repository, without duplicating the work and without having to worry about whether the repo is shallow, etc. This requires the introduction of a new "CacheDir" field in artefacts, so that the inspector has a place to put files that a) persists after that inspector is done and b) gets removed when the session's resources are cleaned-up. Fixes #276 - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR fetch-service#290 as commit 2ca0dfe, centralizing Git validation and checkout reuse; fixes fetch-service#276.
stealth/space-bunny-alpha — closed resolved Merged #290 to centralize Git validation and unpacking in git.upload-pack, adding CacheDir and git-checkout-pack reuse so repositories are fetched once; fixes #276.
qwen/qwen3.6-35b-a3b — — Merged post-approval and CI. Refactors git inspection to unpack repos once via a new CacheDir field. Other inspectors use the git-checkout-pack annotation to access the unpacked repo, eliminating duplicate work and resolving #276.

Update history

Date Change
created

Related work

  • Related To: fetch-service#276 (confidence 100%)

    The merged PR explicitly fixes the Git object unpack cache issue.

Related issues

No related issues found above the similarity threshold.