← Back to issue list

fix(inspectors/apt): rejection fix and additional tests

View original Github issue

Metadata

Project
fetch-service
Number
#308
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #308 via commit ecf2e07: APT translation-file uncompression failures now reject the artifact instead of erroring, with additional inspector tests.

Resolution: closed resolved

Reason: PR #308 was approved and merged as commit ecf2e07, implementing rejection handling for translation-file uncompression failures and adding test coverage.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Reject instead of exiting with error in case of apt translation file uncompression failure, and add extra inspector tests. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #308 via commit ecf2e07: APT translation-file uncompression failures now reject the artifact instead of erroring, with additional inspector tests.
stealth/space-bunny-alpha — closed resolved Merged as ecf2e07 (canonical/fetch-service#308): APT translation-file uncompression failures now reject instead of terminating, with additional inspector tests.
qwen/qwen3.6-35b-a3b — — Merged fix for apt inspector to reject instead of exiting on translation file uncompression failures, plus added inspector tests. Approved by two reviewers and passed CI.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#579 fix(inspectors/apt): recognize small translation files fetch-service merged Merged PR #579 as commit 9a27c6b, fixing APT rejection of translation files smaller than the 1 KiB verification buffer; released in 0.15.1.
78%
#127 inspectors/apt: extend configuration to apt inspectors fetch-service merged Merged PR #127 as commit 26c596c, unifying APT configuration for allowed repositories, distributions, and components across metadata files and .deb packages (CRAFT-3027).
72%
#102 inspectors/apt: fix release validation of translation file fetch-service merged Merged PR #102 in commit 083028d, fixing APT translation validation to compare the downloaded file's SHA-256 digest and size with its Release entry.
72%
#69 feat(inspector): support apt translation fetch-service merged APT translation support was merged in fetch-service PR #69 as commit 8cff6c7, adding Translation-file inspection support.
72%
#101 inspectors/apt: fix release and package state when rejected fetch-service closed APT inspection now records state only for approved packages and releases; the rejection fix was cherry-picked into the feature branch in commit e19a80c.
71%
#98 inspectors/apt: fix typo in error message fetch-service merged Fixed a typo in an APT inspector error message; PR canonical/fetch-service#98 was merged as commit d2f04b2.
71%
#61 inspectors: add apt and deb file inspectors fetch-service merged Merged PR #61 in commit 566f57c, adding stateful APT and DEB inspectors to validate signed InRelease files, Packages.xz indexes, and .deb packages.
70%
#831 Fixed/simplified some tests to isolate them of underlying apt. charmcraft merged Merged PR #831 removed apt-dependent execution from parts/build tests, replacing a null plugin and simplifying build fixtures; merged as commit 6418a586.
70%
#83 docs: add apt inspectors reference fetch-service merged Merged PR #83 as commit 27edc4d, adding reference documentation for APT release, package, and translation inspectors.
70%