fix(inspectors/apt): rejection fix and additional tests
Metadata
Current evaluation
Merged fix for apt inspector to reject instead of exiting on translation file uncompression failures, plus added inspector tests. Approved by two reviewers and passed CI.
Suggested action: —
No scores available.
Issue body
Reject instead of exiting with error in case of apt translation file
uncompression failure, and add extra inspector tests.
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for apt inspector to reject instead of exiting on translation file uncompression failures, plus added inspector tests. Approved by two reviewers and passed CI. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #579 fix(inspectors/apt): recognize small translation files | fetch-service | merged | Merged fix for #574 that adjusts the format verification buffer to accept translation files smaller than the previous threshold. Approved by two reviewers and passed CI checks. | |
| #69 feat(inspector): support apt translation | fetch-service | merged | Merged to add apt translation support to the inspector. Approved by one reviewer, introducing 446 lines across eight files. Requires rebasing onto feature/launchpad-integration to resolve test conflicts. | |
| #548 fix(inspectors/apt): allow translation file request by name | fetch-service | merged | Merged update allowing the apt translation inspector to request files by name, like Translation-en, in addition to SHA256 hash URLs. Approved by two reviewers, passed all CI checks, and modified three files with 33 additions and 7 deletions. | |
| #102 inspectors/apt: fix release validation of translation file | fetch-service | merged | Merged a fix for the APT inspector to validate translation file release data. The change ensures actual file digest and size match the release entry. Accepted and merged without code modifications. | |
| #75 inspectors/apt: add test for packages verification in release | fetch-service | merged | Merged after approval by two reviewers. The update adds a test for packages verification in the release process under inspectors/apt. Despite a zero-line diff, the change was successfully integrated. | |
| #127 inspectors/apt: extend configuration to apt inspectors | fetch-service | merged | Merged extension of apt inspectors to share configuration for allowed repositories, dists, and components. Approved by two reviewers, passed CI, and modified 14 files. Resolves CRAFT-3027. | |
| #98 inspectors/apt: fix typo in error message | fetch-service | merged | Merged a pull request fixing a typo in an error message within the inspectors/apt module. Approved by a reviewer, passed CI checks, and successfully integrated into the codebase. | |
| #581 refactor: reformat apt translation tests | fetch-service | merged | Merged refactoring of apt translation tests with zero functional changes. Approved by two reviewers and passed CI checks. The maintainer integrated the formatting updates across one file (+76/-36 lines). | |
| #100 inspectors/apt: fix release signature validation | fetch-service | merged | Merged by maintainer cmatsuoka to fix release signature validation in the apt inspectors. The change was accepted and closed without review comments or CI checks, successfully resolving the validation issue. | |
| #428 fix(i/apt): keep existing packages metadata in inspector state | fetch-service | merged | Merged a fix for the apt inspector to preserve existing package metadata instead of overwriting it with empty content during repeated downloads. Approved by two reviewers and passed all CI checks. |