← Back to issue list

fix: false positive in store info inspection

View original Github issue

Metadata

Project
fetch-service
Number
#477
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged fix for false positives in store info inspection. Adjusts bld bin validation to accept non-tarball xz archives and relaxes artifact detection heuristics for JSON responses. Approved by three reviewers and passed all CI checks.

Suggested action: —

No scores available.

Issue body

Fix the bld bin validation to not reject files that are non-tarball xz archives. Additionally, reduce rejections in artifact detection heuristics to prevent false positives with JSON responses with similar schemas. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- FETCH-33

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged fix for false positives in store info inspection. Adjusts bld bin validation to accept non-tarball xz archives and relaxes artifact detection heuristics for JSON responses. Approved by three reviewers and passed all CI checks.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#400 fix: bin inspector must not reject non-tar artifacts fetch-service merged Merged fix updating the bin inspector to skip non-tar xzipped artifacts instead of returning an error. Approved by two reviewers and passed CI, resolving the artifact rejection issue.
79%
#472 False positives in store Info API inspector fetch-service closed False positives in the store Info API inspector rejecting valid xz archives were resolved in pull request #477. Artifact detection heuristics were adjusted to correctly handle non-tar xz files and prevent unnecessary rejections.
79%
#398 feat: add store api and bld bin package inspectors fetch-service merged Merged after two approvals and passing CI. Introduces store API and bld bin package inspectors to verify SHA3-384 digests and extract metadata from xz tarballs. Changes span 16 files with over 1100 lines added.
73%
#439 fix(i/store): inspect bld bin requests in store inspector fetch-service merged Merged a fix enabling the store inspector to validate and set build bin requests to pending for strict sessions. Approved by two reviewers, passed CI, and integrated.
71%