← Back to issue list

Linters: enable gocyclo, errcheck and gosec

View original Github issue

Metadata

Project
fetch-service
Number
#495
Type
issue
State
open
Author
upils
Labels
Type: Enhancement Status: Triaged
Created
Updated
Closed
—

Current evaluation

Enhancement to enable gocyclo, errcheck and gosec in .github/.golangci.yaml and fix the resulting findings. Maintainer-authored, Triaged, tracked internally as FETCH-63; attempt PR #545 was closed unmerged.

Suggested action: keep open

Reason: The pinned .github/.golangci.yaml still enables only govet, ineffassign, nakedret, staticcheck and unused, so the requested linters are not enabled and the issue is not resolved. It carries Type: Enhancement + Status: Triaged labels and an author-maintainer request backed by an internal ticket (FETCH-63 per the bot sync comment), so it should stay open; the sole linked PR #545 was closed unmerged after "the author repeatedly applied an opposite fix to the reviewer's requested defer cleanup", leaving the work undone. Impact is moderate (code-quality/security posture, gosec adds real value) but the change is codebase-wide — the body itself states the linters "currently return many errors" and must be tuned "consistent with other projects", which is open-ended scope and explains the elevated complexity.

Evaluated by: mr-cal-bot

Impact: 40 Quick Win: 8 Complexity: 68 Confidence: 82 Actionability: 65

Issue body

### What needs to get done Enable gocyclo, errcheck and gosec in the the golangci-lint configuration. Tune the configuration to be consistent with other projects. Solve returnes errors. ### Why it needs to get done These linters currently return many errors but are part of the "reasonable" set of linters we want to enable.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 40
Quick Win: 8
Complexity: 68
Confidence: 82
Actionability: 65
keep open Enhancement to enable gocyclo, errcheck and gosec in .github/.golangci.yaml and fix the resulting findings. Maintainer-authored, Triaged, tracked internally as FETCH-63; attempt PR #545 was closed unmerged.
stealth/space-bunny-alpha
Impact: 45
Quick Win: 11
Complexity: 70
Confidence: 94
Actionability: 80
keep open Triaged enhancement to enable gocyclo, errcheck and gosec and address existing findings. Tracked as FETCH-63, but PR #545 closed unmerged after unresolved reviewer feedback.
qwen/qwen3.6-35b-a3b
Impact: 35
Quick Win: 16
Staleness: 75
Complexity: 55
Confidence: 70
Support Request: 10
keep open Enable gocyclo, errcheck, and gosec linters in golangci-lint config and fix resulting errors. Triaged but inactive for ~9 months.

Update history

Date Change
created

Related work

  • Related To: canonical/fetch-service#545 (confidence 92%)

    PR 'ci: enable gocyclo, errcheck and gosec linters' directly implements this issue but was closed unmerged after unresolved reviewer feedback on defer cleanup, so the work is available as a reference yet incomplete.

Related issues

Issue Project State Summary Similarity
#545 ci: enable gocyclo, errcheck and gosec linters fetch-service closed PR #545 closed unmerged after repeated conflicts over defer cleanup; gocyclo, errcheck, gosec, and G115 remain disabled in the linter configuration.
84%