← Back to issue list

feat: inspector for snapd session authentication

View original Github issue

Metadata

Project
fetch-service
Number
#507
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #507 (commit 9d5c779) adding the snapd session authentication inspector (snap.auth-sessions), which validates requests to the snapcraft.io auth/sessions endpoint and checks responses for a macaroon token. Closes issue #510.

Resolution: closed resolved

Reason: PR #507 was approved and merged to main as commit 9d5c779, adding inspectors/snap/auth_sessions.go (plus unit tests and the application/x.canonical.snapd-auth-sessions mimetype). The body states "Fixes #510", and issue #510 ('Add snapd auth/sessions inspector') is now closed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This commit introduces a new inspector for handling snapd session authentication requests and responses. The inspector validates requests to the snapcraft.io auth sessions endpoint and verifies that responses contain properly formatted session authentication data with a macaroon token. Fixes #510 - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- FETCH-55

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #507 (commit 9d5c779) adding the snapd session authentication inspector (snap.auth-sessions), which validates requests to the snapcraft.io auth/sessions endpoint and checks responses for a macaroon token. Closes issue #510.
stealth/space-bunny-alpha — closed resolved Merged PR #507 (9d5c779), adding a snapd session-authentication inspector that validates auth-session requests and macaroon-bearing responses, fixing #510.
qwen/qwen3.6-35b-a3b — — Merged. Introduces an inspector for snapd session authentication, validating snapcraft.io auth requests and verifying response macaroon tokens. Resolves issue #510. Approved by two reviewers with all CI checks passing.

Update history

Date Change
created

Related work

  • Duplicate Of: canonical/fetch-service#510 (confidence 90%)

    PR #507 declares 'Fixes #510'; the issue it implements was closed by the merge. Direction is inverted (the PR fixes the issue), listed here as the directly linked item.

  • Related To: canonical/fetch-service#503 (confidence 70%)

    Commit 8ba29b4 added the sibling snapd authentication nonce inspector, part of the same snap auth inspector series.

  • Related To: canonical/fetch-service#519 (confidence 60%)

    Commit 286d79b added the device authentication request-id inspector, another snapd auth endpoint inspector in the same series.

Related issues

Issue Project State Summary Similarity
#503 feat: add inspector for snapd authentication nonce fetch-service merged Merged #503 as 8ba29b4, adding the snapd authentication-nonce inspector and fixing fetch-service#511.
77%
#510 Add snapd auth/sessions inspector fetch-service closed Snapd auth/sessions inspection was implemented in canonical/fetch-service#507 (commit 9d5c779), including tests; #510 was subsequently closed.
76%
#519 feat: add inspector for device authentication request-id fetch-service merged Merged PR #519 as commit 286d79b, adding the snap.auth-request-id inspector for device authentication API calls and resolving issue #515.
75%