← Back to issue list

fix(i/deb): parse uncompressed control and data files

View original Github issue

Metadata

Project
fetch-service
Number
#596
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 4a235b6; adds plain "control.tar" and "data.tar" ar-member cases in inspectors/deb/deb.go so uncompressed .deb archives (e.g. linux-firmware 20240318.git3b128b60-0ubuntu2.25) get inspected; docs/reference/deb.rst updated.

Resolution: closed resolved

Reason: PR #596 was approved (2 reviewers) with all CI checks passing and merged to main as commit 4a235b6. The current inspectors/deb/deb.go readDebMetadata switch handles uncompressed control.tar and data.tar by passing the ar reader directly to parseControlTar/parseDataTar, and deb.rst documents the uncompressed control.tar.* layout.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Update the Debian package inspector to handle .deb archives whose control.tar and/or data.tar members are stored uncompressed, enabling metadata extraction for packages like linux-firmware_20240318.git3b128b60-0ubuntu2.25_arm64.deb that use this layout. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 4a235b6; adds plain "control.tar" and "data.tar" ar-member cases in inspectors/deb/deb.go so uncompressed .deb archives (e.g. linux-firmware 20240318.git3b128b60-0ubuntu2.25) get inspected; docs/reference/deb.rst updated.
stealth/space-bunny-alpha — closed resolved Merged fetch-service#596 as commit 4a235b6, adding support for uncompressed Debian control.tar and data.tar members so affected .deb packages can be inspected.
stealth/space-bunny-alpha — closed resolved Merged in canonical/fetch-service#596 (commit 4a235b6): the Debian inspector now parses uncompressed control.tar and data.tar members, restoring metadata extraction for affected .deb packages.
qwen/qwen3.6-35b-a3b — — Merged. Updates the Debian package inspector to parse uncompressed control.tar and data.tar files within .deb archives. Approved by two reviewers, passed all CI checks, and refactored to avoid stacked deferred calls. (+25/-4 lines)

Update history

Date Change
created

Related work

  • Related To: canonical/fetch-service#339 (confidence 55%)

    Earlier commit 8ea9e9a 'fix(inspectors/deb): handle more compression methods' established the per-compression switch pattern that #596 extended with uncompressed members.

Related issues

Issue Project State Summary Similarity
#339 fix(inspectors/deb): handle more compression methods fetch-service merged Merged PR #339 as 8ea9e8e: DEB inspection now supports xz control files and gzip data files, and rejects packages missing parsed name/version; fixes #337.
74%
#337 Debs are approved even if control file uses unsupported compression fetch-service closed Fixed by merged PR #339 (commit 8ea9e8e), adding xz-compressed control-file and gzip-compressed data-file support to the Debian inspector.
74%