fix: refactor service shutdown to prevent races
Metadata
Current evaluation
Refactors service shutdown to prevent race conditions in fetchctl socket server, HTTP proxy, and control API server. Approved by 2 reviewers with 0 unresolved comments; most CI passing.
Suggested action: needs review
Reason: PR has 2 approvals and 0 unresolved review comments, indicating it's ready to merge. However, last activity was 60 days ago, suggesting it may have slipped through the cracks. A maintainer should review and land it or request any final changes.
Impact:
70
Quick Win:
38.5
Staleness:
65
Complexity:
45
Confidence:
75
Issue body
Rework the shutdown path for the fetchctl socket server, HTTP proxy,
and control API server to ensure the process exits cleanly without
hangs or races.
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
70
Quick Win:
38.5
Staleness:
65
Complexity:
45
Confidence:
75
|
needs review | Refactors service shutdown to prevent race conditions in fetchctl socket server, HTTP proxy, and control API server. Approved by 2 reviewers with 0 unresolved comments; most CI passing. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #177 feat(service): implement idle auto-shutdown | fetch-service | merged | Merged. Implements idle auto-shutdown, terminating the service after inactivity with no active sessions or API calls. Also improves proxy and control server crash handling. Approved by two reviewers and passed CI. | |
| #474 feat: set the fetch-service to idle shutdown | craft-application | merged | Merged a pull request configuring the fetch-service to automatically shut down after five minutes of inactivity. Approved by two reviewers, passed CI checks, and implemented with minimal changes across two files. |