← Back to issue list

Be stricter when mounting and safer when umounting

View original Github issue

Metadata

Project
imagecraft
Number
#126
Type
pull request
State
merged
Author
upils
Labels
—
Created
Updated
Closed

Current evaluation

Merged #126 via commit 15871f5, adding missing-mountpoint validation and best-effort unmount cleanup; fixes #118.

Resolution: closed resolved

Reason: Pull request #126 was merged as commit 15871f5. It makes Mount.mount() reject absent mountpoints and allows cleanup to continue unmounting remaining directories after errors.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- - Raise an exception when the mountpoint does not exist in Mount.mount() - Catch exceptions when calling Mount.umount() in `_cleanup` to umount as many dirs as possible from the given list. Fixes #118 CRAFT-4402

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #126 via commit 15871f5, adding missing-mountpoint validation and best-effort unmount cleanup; fixes #118.
stealth/space-bunny-alpha — closed resolved Merged stricter mount handling: Mount.mount() rejects missing mountpoints, while _cleanup continues unmounting remaining directories after errors. Stated fixes: #118 (CRAFT-4402).
qwen/qwen3.6-35b-a3b — — Merged. Enforces strict mountpoint validation by raising an exception if missing, and safer unmounting by catching exceptions during cleanup to continue unmounting remaining directories. Resolves #118 and CRAFT-4402.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Implements stricter mountpoint validation by raising an exception if missing, and safer unmounting by catching exceptions during cleanup to unmount as many directories as possible. Resolves #118 and CRAFT-4402.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#118 Be stricter when mounting and safer when umounting imagecraft closed Fixed by merged canonical/imagecraft#126 (15871f5): missing mountpoints now fail early, and chroot cleanup attempts every unmount before reporting errors.
83%