← Back to issue list

Add filesystems model

View original Github issue

Metadata

Project
imagecraft
Number
#151
Type
pull request
State
merged
Author
upils
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 8887fc1, adding the filesystems model and required section for IMAGECRAFT-24; the remaining spread failure was confirmed as pre-existing.

Resolution: closed resolved

Reason: PR #151 was approved and merged as commit 8887fc1. The author added the required filesystems section, and review confirmed the remaining spread failure also occurred before the PR.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Implement the `filesystems` model as specified in https://docs.google.com/document/d/1MtDUlGkq2txvylU2Gzym3R8zgVALAWD9w6GSGix4fYs/edit?tab=t.0 The actual work of using these filesystems definitions to properly distribute the content to partitions will be done by craft-parts in a near future. Wait to update the how-to in the docs until this is done. IMAGECRAFT-24

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 8887fc1, adding the filesystems model and required section for IMAGECRAFT-24; the remaining spread failure was confirmed as pre-existing.
stealth/space-bunny-alpha — closed resolved Merged PR #151 in commit 8887fc1, adding the filesystems model for IMAGECRAFT-24 and the required filesystems data; the remaining spread failure was confirmed as pre-existing.
stealth/space-bunny-alpha — closed resolved Merged PR #151 (commit 8887fc1) added the filesystems model for IMAGECRAFT-24 and addressed reviewer feedback by adding the required section; remaining spread failures were pre-existing.
qwen/qwen3.6-35b-a3b — — Merged after implementing the filesystems model per specification. Addressed reviewer feedback on failing spread tests by adding the required section. Approved by two reviewers and passed CI checks before merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged the filesystems model implementation. Pre-existing spread test failures were noted but deemed unrelated. The author added the required configuration, and the changes were merged.

Update history

No update history recorded yet.

Related work

  • Related To: imagecraft#191 (confidence 95%)

    Later documentation PR adding the filesystems model to the reference documentation.

Related issues

Issue Project State Summary Similarity
#191 docs: add filesystems model to reference imagecraft merged Merged into main as eac678b, adding the filesystems model to Imagecraft's reference documentation; all reported CI checks passed.
79%
#769 feat: add filesystems model craft-application closed PR adding a filesystems model to craft-application was closed unmerged; maintainer upils redirected the work to canonical/imagecraft#151 (commit 8887fc1), which implemented it in imagecraft.
76%