← Back to issue list

FR-5869 - Improve test coverage

View original Github issue

Metadata

Project
imagecraft
Number
#18
Type
pull request
State
merged
Author
upils
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #18 as commit eb5a438, raising coverage to about 90% while renaming the germinate plugin, refactoring packing, consolidating dependencies, and tightening platform support.

Resolution: closed resolved

Reason: The approved PR was merged into main as eb5a438. Codecov reported 91.11% patch coverage, while tests and implementation refactors delivered the requested coverage improvements.

Evaluated by: mr-cal-bot

No scores available.

Issue body

I reached ~90% coverage and did not go any further on purpose because the remaining code will likely change in the coming weeks, so there is no point testing it I think. Some highlights of the PR: - I renamed the `germinate` plugin to `ubuntu-seed`, to apply what we discussed in the spec. - I fixed a lot of small things to satisfy the different linters. So it feels a lot has changed but most of it is just formatting or typing stuff. - I removed the `requirements.txt` and gather dependencies declaration in the `pyproject.toml` to avoid duplication and ease maintenance. - Based on what I read in the other *craft applications, I moved the “packing” logic in a ImagecraftPackage “service” and added a basic “ServiceFactory” - I dropped explicit support for windows/macos because for now it does not make sense to run imagecraft on these OS I think but if in the end everything is executed in a lxd container (or another provider) we could probably re-add it. - To avoid linters fighting each other I bumped the python minimum supported version to 3.10. I looked at other *craft applications and most of them do the same. We could discuss if we absolutely want to run imagecraft on python 3.8, but since we will most likely distribute it as a snap, it should not be a big problem at least for ubuntu users.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #18 as commit eb5a438, raising coverage to about 90% while renaming the germinate plugin, refactoring packing, consolidating dependencies, and tightening platform support.
stealth/space-bunny-alpha — closed resolved Merged #18 raised test coverage to about 90% and refactored packing/services, dependencies, linting, Python support, platform scope, and the plugin name.
stealth/space-bunny-alpha — closed resolved Merged PR #18, raising coverage to about 90% while refactoring packing, renaming germinate to ubuntu-seed, consolidating dependencies, and updating lint, Python, and platform support.
stealth/space-bunny-alpha — closed resolved Merged in canonical/imagecraft#18 as eb5a438, raising coverage to 91.11% and refactoring packing, dependencies, plugin naming, and minimum Python support.
qwen/qwen3.6-35b-a3b — — Merged. Increased test coverage to ~90% by refactoring packing logic, renaming the germinate plugin to ubuntu-seed, consolidating dependencies, dropping Windows/macOS support, bumping Python to 3.10, and fixing linters.
qwen3.6-35b-a3b-mtp-q6 — — Merged after raising test coverage to ~91%. Renamed germinate plugin to ubuntu-seed, consolidated dependencies, refactored packing logic, dropped Windows/macOS support, and bumped Python minimum to 3.10. Integrated after passing checks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#461 test: improve test coverage fetch-service merged Merged PR #461 via commit 76d6134, adding 270 lines of tests across three files; all CI checks passed and two reviewers approved.
70%
#278 tests: additional tests to improve coverage fetch-service merged Merged coverage-focused test additions via #278 (commit 095e41a), changing 10 files (+386/-60) with two approvals and no reported CI failures.
70%