feat: add configure hook
Metadata
Current evaluation
PR #183 merged as b677710, adding a configure hook that validates the provider snap setting and fixes #182.
Resolution: closed resolved
Reason: The approved PR #183 was merged at commit b677710. Its configure hook validates the provider setting through SnapConfig, resolving imagecraft#182.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
---
Add a configure snap hook to configure the default provider by calling `snap set imagecraft provider=multipass`.
Heavily inspired from https://github.com/canonical/snapcraft/pull/3898
IMAGECRAFT-35
Fixes #182
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #183 merged as b677710, adding a configure hook that validates the provider snap setting and fixes #182. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #183 as b677710, adding a configure hook that validates provider snap configuration, plus spread tests and docs; fixes #182. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #183 as b677710, adding a configure hook that validates snap-configured provider values through SnapConfig and fixes #182. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in imagecraft#183 (commit b677710), adding a configure hook that reads and validates the snap-configured provider via SnapConfig, resolving #182. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #183 merged as commit b677710, adding snap/hooks/configure which validates the `provider` snap config (lxd/multipass) via craft_application SnapConfig, plus a spread test. Closes #182. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/imagecraft#183 (b677710), adding a configure hook that validates snap-configured provider values through SnapConfig and fixes #182. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #183 as b677710, adding a configure snap hook that validates snap-configured providers through SnapConfig and fixes #182. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/imagecraft#183 (b677710), adding a configure snap hook that validates snap-configured provider values through SnapConfig and fixes #182. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #183 as commit b677710, adding a configure snap hook that validates the provider setting through SnapConfig; fixes #182. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #183 (commit b677710), adding a configure snap hook that configures the default provider through the existing SnapConfig model and fixes #182. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #183 as commit b677710, adding a configure hook that sets the default provider to Multipass and fixes #182. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #183 (commit b677710), adding a configure snap hook and using existing SnapConfig provider settings to configure the default provider. Resolves #182. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged imagecraft#183 (b677710), adding a configure hook that validates snap configuration, including the provider setting, and closing #182. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to implement a configure snap hook for setting the default provider. Resolves #182 by utilizing the existing SnapConfig model, addressing reviewer suggestions to streamline configuration management. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to add a configure snap hook setting the default provider via snap set imagecraft provider=multipass, fixing #182. Reviewers recommended using the existing SnapConfig model instead, which the author acknowledged as a simpler approach. |
Update history
No update history recorded yet.
Related work
-
Related To:
imagecraft#182
(confidence 100%)
PR #183 explicitly fixes #182, whose closure record cites merge commit b677710.
-
Related To:
canonical/snapcraft#3898
(confidence 95%)
The configure-hook implementation was heavily inspired by this Snapcraft PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #473 snap: add configure hook with support for provider (CRAFT-363) | charmcraft | merged | Merged as bf350c68, adding a snap configure hook that reads the provider setting and rejects values other than lxd or multipass. | |
| #182 Add a `configure` snap hook | imagecraft | closed | Added snap configuration for provider selection and documented snap set imagecraft provider=multipass; fixed by canonical/imagecraft#183 in commit b677710. |