← Back to issue list

feat: add configure hook

View original Github issue

Metadata

Project
imagecraft
Number
#183
Type
pull request
State
merged
Author
upils
Labels
—
Created
Updated
Closed

Current evaluation

Merged to implement a configure snap hook for setting the default provider. Resolves #182 by utilizing the existing SnapConfig model, addressing reviewer suggestions to streamline configuration management.

Suggested action: —

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Add a configure snap hook to configure the default provider by calling `snap set imagecraft provider=multipass`. Heavily inspired from https://github.com/canonical/snapcraft/pull/3898 IMAGECRAFT-35 Fixes #182

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged to implement a configure snap hook for setting the default provider. Resolves #182 by utilizing the existing SnapConfig model, addressing reviewer suggestions to streamline configuration management.
qwen3.6-35b-a3b-mtp-q6 — — Merged to add a configure snap hook setting the default provider via snap set imagecraft provider=multipass, fixing #182. Reviewers recommended using the existing SnapConfig model instead, which the author acknowledged as a simpler approach.
qwen3.6-35b-a3b-mtp-q6 — — Merged a configure snap hook to set the default provider. Aligned with the existing SnapConfig model per reviewer feedback to handle provider configuration via snap settings and environment variables, fixing #182.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#473 snap: add configure hook with support for provider (CRAFT-363) charmcraft merged Merged. Added a snap configure hook to validate the provider setting, restricting it to multipass or lxd. Updated requirements to include snap-helpers. Validation errors on invalid values but is reserved for future use. Approved by two reviewers.
80%