← Back to issue list

fix(test): build on devel, which can be any base

View original Github issue

Metadata

Project
imagecraft
Number
#249
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a test fix switching the build target from Ubuntu 24.04 to devel to bypass base version checks. Approved by two reviewers and passed CI checks before merging.

Suggested action:

No scores available.

Issue body

Changes the tests from building on 24.04 (which requires using 24.04) to building on devel (which skips the base check). --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a test fix switching the build target from Ubuntu 24.04 to devel to bypass base version checks. Approved by two reviewers and passed CI checks before merging.
qwen3.6-35b-a3b-mtp-q6 Merged. Updated tests to build on devel instead of 24.04, bypassing strict base version checks. Lint and test suites passed, and the change was successfully integrated.
qwen3.6-35b-a3b-mtp-q6 Merged a test fix that switches the build target from Ubuntu 24.04 to devel, bypassing the strict base version check. The change was accepted and integrated into the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1074 fix: ubuntu@26.04 is not a valid build-base yet rockcraft merged Merged a fix restricting build-base to stable Ubuntu releases and devel, excluding ubuntu@26.04 until stabilization. Approved by two reviewers and merged to resolve issue #1069, despite one failing CI check.
77%
#4540 fix(lifecycle): return correct base when using devel for build-base (… snapcraft merged Merged a fix to return the correct base when using devel for build-base. Approved by two reviewers, the change spans seven files. Codecov noted one uncovered line, but the pull request was successfully merged.
76%
#4755 tests: fix devel base snap test snapcraft merged Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change.
76%
#1020 feat(project): add ubuntu@26.04 as a 'devel' base rockcraft merged Added Ubuntu 26.04 as a 'devel' base. Merged after approval by two reviewers, modifying 13 files (+85/-30). CI checks passed prior to merge.
75%
#4523 fix(lifecycle): return correct base when using devel for build-base snapcraft merged Merged fix for get_effective_base() returning devel for build-base, preventing invalid LD_LIBRARY_PATH paths. Approved by three reviewers, passed CI, and resolves #4508. Reviewers requested targeting hotfix/8.0 and discussed a core24 validator.
74%
#4922 tests: disable `build-base: devel` spread tests snapcraft merged Merged a change to temporarily disable build-base: devel spread tests, bypassing failures caused by 24.10 buildd images and systemd-resolved. The fix addresses issue #4910 and will be revisited once debugging resources are available.
73%
#5796 fix(test): enable test to run on platforms other than 24.04 snapcraft merged Merged a fix enabling a previously 24.04-specific test to execute across multiple Ubuntu platforms. Approved by reviewers, passed CI validation, and successfully integrated into the main branch.
72%
#980 fix(tests): fix tests that were broken on Ubuntu 26.04 craft-application merged Merged a fix for tests failing on Ubuntu 26.04. Approved by two reviewers and passing all CI checks, the change modifies two files with six additions and two deletions to resolve platform-specific test failures.
72%
#4068 meta: allow support for `build-base: devel` snapcraft merged Merged after approval and CI checks. Enables build-base: devel support and sets the grade to devel. A testing issue requiring manual apt update on the lunar image was resolved via a craft-providers update.
71%
#955 feat(project): set 26.04 as the current 'devel' base craft-application merged Merged via squash after approval from two reviewers and passing all CI checks. Updates the project's development base to Ubuntu 26.04 across three files.
71%