← Back to issue list

feat(volumes): allow manually-defined partition numbers

View original Github issue

Metadata

Project
imagecraft
Number
#252
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged. Enables manual partition numbering in volume structures, requiring all partitions on a volume to use manual IDs. Approved by three reviewers, passed most CI checks despite failing spread tests on Ubuntu variants, and modified 10 files.

Suggested action:

No scores available.

Issue body

This adds the ability to manually define the number of a partition in a volume structure. If any partition on a volume has a manually defined partition number, all partitions on that volume must have manually defined partition numbers. IMAGECRAFT-74 IMAGECRAFT-28 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Enables manual partition numbering in volume structures, requiring all partitions on a volume to use manual IDs. Approved by three reviewers, passed most CI checks despite failing spread tests on Ubuntu variants, and modified 10 files.
qwen3.6-35b-a3b-mtp-q6 Merged. Adds support for manually defining partition numbers in volume structures, requiring all partitions on a volume to use manual numbering if any are set. Resolves IMAGECRAFT-74 and IMAGECRAFT-28.
qwen3.6-35b-a3b-mtp-q6 Merged feature allowing manual partition number assignment in volume structures. Enforces that all partitions on a volume use manual numbering if any are manually defined. Resolves IMAGECRAFT-74 and IMAGECRAFT-28.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#286 feat(volumes): add some more GPT types imagecraft merged Merged addition of extra GPT partition types to volumes. Approved with all CI checks passing. Implemented as a temporary testing workaround and expected to be superseded by PRs #276 and #285.
73%