← Back to issue list

style: migrate from overrides library to typing.override

View original Github issue

Metadata

Project
imagecraft
Number
#273
Type
pull request
State
merged
Author
Spilsed
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #273 as commit efa5479, replacing the overrides library with typing.override and resolving #264 in preparation for Python 3.14.

Resolution: closed resolved

Reason: PR #273 was merged as commit efa5479 after maintainer review. Its change migrated override decorators to typing_extensions.override and explicitly resolved issue #264.

Evaluated by: mr-cal-bot

No scores available.

Issue body

<!-- Describe your changes --> Resolves #264 by removing old references to `overrides` and changes them to `typing.override` - [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #273 as commit efa5479, replacing the overrides library with typing.override and resolving #264 in preparation for Python 3.14.
stealth/space-bunny-alpha — closed resolved Merged #273 at commit efa5479, replacing the overrides library with typing.override and resolving #264 in preparation for Python 3.14.
stealth/space-bunny-alpha — closed resolved Merged in #273 as efa5479, replacing the overrides library with typing.override and resolving #264 in preparation for Python 3.14.
stealth/space-bunny-alpha — closed resolved Merged PR #273 replaced the overrides library with typing.override, resolving #264 and completing the Python 3.14 compatibility cleanup.
qwen/qwen3.6-35b-a3b — — Merged after migrating from the overrides library to typing.override, resolving issue #264. Reviewer feedback regarding an accidental formatter change in docs/conf.py was addressed. Approved by three reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged after migrating from the overrides library to typing.override to resolve issue 264. Reviewer requested reverting accidental formatter changes to docs/conf.py, which the author addressed before final merge.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#264 Migrate from `overrides` library to `typing.override` imagecraft closed Merged PR #273 (commit efa5479) replaced the overrides dependency with typing.override in preparation for Python 3.14.
88%
#6058 Migrate from `overrides` library to `typing.override` snapcraft closed Fixed by PR #6068 (commit be66fee8b), replacing the overrides library with typing_extensions.override for Python 3.14 readiness.
86%
#1268 style: switch from the `overrides` package to `typing.override` craft-parts merged Merged PR #1268, replacing the `overrides` package with `typing.override` in commit a70bf95f to restore Python 3.14 compatibility while retaining lint-time marking.
82%
#6068 feat: migrate from overrides to typing_extensions.override snapcraft merged Merged PR #6068 in commit be66fee8b migrated 50 files from overrides to typing_extensions.override and closed #6058.
74%