← Back to issue list

ci: fix failing tests

View original Github issue

Metadata

Project
imagecraft
Number
#291
Type
pull request
State
merged
Author
smethnani
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 6357854 (ci: fix failing tests (#291)): added ignore_outdated arg to test_lifecycle.py, pinned pygit2<1.15.0 for libgit2-1.7 on core24, and bumped rustc/cargo for maturin 1.12. IMAGECRAFT-103.

Resolution: closed resolved

Reason: The PR was approved by 2 reviewers with all CI checks passing and merged into main as commit 6357854 (4 files, +24/-62). Current pyproject.toml still carries the pygit2>=1.13.0,<1.15.0 pin with the libgit2-1.7 comment, tests/unit/services/test_lifecycle.py passes ignore_outdated, and snap/snapcraft.yaml now wires rustc/cargo for maturin (since bumped to 1.91), confirming the fixes landed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR: - adds expected `ignore_outdated` arg in test_lifecycle.py - pins max version of pygit2 to < 1.15.0 to work with libgit2-1.7 - updates rustc and cargo to 1.89 to work with maturin 1.12 IMAGECRAFT-103 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 6357854 (ci: fix failing tests (#291)): added ignore_outdated arg to test_lifecycle.py, pinned pygit2<1.15.0 for libgit2-1.7 on core24, and bumped rustc/cargo for maturin 1.12. IMAGECRAFT-103.
stealth/space-bunny-alpha — closed resolved Merged #291 (6357854): fixed CI tests by updating lifecycle test arguments, capping pygit2 below 1.15 for libgit2 1.7, and updating Rust/Cargo to 1.89 for maturin 1.12.
qwen/qwen3.6-35b-a3b — — Merged after passing all CI checks and receiving two approvals. Fixed failing tests by adding an expected argument, pinning pygit2 below 1.15.0, and updating the Rust toolchain to 1.89 for maturin 1.12 compatibility.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Resolved failing CI by adding the ignore_outdated argument to test_lifecycle.py, pinning pygit2 under 1.15.0 for libgit2-1.7 compatibility, and updating rustc and cargo to 1.89 for maturin 1.12. Addresses IMAGECRAFT-103.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#235 fix(build): update rustc and cargo imagecraft merged Merged in canonical/imagecraft#235 (commit 8ddd13b), updating rustc and cargo for maturin 1.10 compatibility; all reported CI checks passed.
75%