← Back to issue list

test: add overlay plugin integration test

View original Github issue

Metadata

Project
imagecraft
Number
#349
Type
pull request
State
merged
Author
smethnani
Labels
—
Created
Updated
Closed

Current evaluation

Merged following successful CI checks and dual reviewer approval. The update adds integration tests for overlay plugin commands and bumps the craft-parts dependency across eight files.

Suggested action: —

No scores available.

Issue body

- Updates craft-parts - Adds integration test for overlay commands in plugins --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged following successful CI checks and dual reviewer approval. The update adds integration tests for overlay plugin commands and bumps the craft-parts dependency across eight files.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 20
Confidence: 80
needs review Adds an integration test for overlay plugin commands. Author is a maintainer, PR is 24 days old with no comments or activity since creation. Lint and tests pass. Awaiting maintainer review/merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#299 feat: enable override-overlay imagecraft merged Merged following approval from two reviewers and passing CI checks. Updated craft-parts to ~2.30 to enable override-overlay support and added a corresponding spread test.
78%
#110 feat: Support overlay imagecraft merged Merged to enable the overlay feature, provide a bare base, and add spread tests. Approved by two reviewers with passing CI checks. Resolves #98 and CRAFT-4269 across 18 files.
75%
#77 tests: add integration tests for application plugins (CRAFT-69) craft-parts merged Merged integration tests for application plugins. Approved by two reviewers, passed CI checks, and added 203 lines across two files to verify plugin registration and functionality.
75%
#407 features: reorganize overlay feature tests craft-parts merged Merged changes reorganizing overlay feature tests to run with the feature enabled and disabled. Fixes part environment setup to only set CRAFT_OVERLAY when active. Approved by reviewer and passed CI.
74%
#602 fix: enable overlays in _enable_craft_parts_features() rockcraft merged Merged a fix enabling overlays in _enable_craft_parts_features(). Approved by two reviewers with passing CI checks. A minor testing note was dismissed when the reviewer used the correct environment. The change was successfully integrated.
74%
#147 executor: update overlay package list (CRAFT-581) craft-parts merged Merged update to the overlay package list prior to lifecycle execution when overlays are enabled. Approved by reviewer, passed CI checks, and modified 4 files (+10/-1).
72%
#17 requirements: update dependencies rockcraft merged Merged after reviewer approval and passing CI checks. Updated dependencies to craft-parts, adding go plugin and fuse-overlayfs support across nine files.
72%
#1249 build(deps): fix overlay migration bug through craft-parts rockcraft merged Resolved overlay migration bug by updating craft-parts. Merged after reviewer approval and passing CI checks. Closes #1217. Diff contains 37 additions and 6 deletions across five files.
72%
#56 Add a fuller integration test, and multiple minor changes to support it craft-archives merged Merged. Added a comprehensive integration test for repo.install() with minor supporting changes across seven files. Approved, passed CI, and achieved 100% diff coverage. Resolves CRAFT-1649 and CRAFT-1682.
71%
#1165 feat: enable override-overlay rockcraft merged Merged. Updates craft-parts to enable the override-overlay key, replaces overlay-script in tests, and updates documentation. Reviewers approved the changes and confirmed upgrading sphinx-terminal resolves linting errors. All required checks passed before merge.
71%