← Back to issue list

test: add core pi boot spread test

View original Github issue

Metadata

Project
imagecraft
Number
#394
Type
pull request
State
merged
Author
smethnani
Labels
—
Created
Updated
Closed

Current evaluation

PR #394 (smethnani) merged, adding a Pi core spread boot test that extracts and passes kernel, initrd and device tree to QEMU and runs install and run modes; approved by 2 reviewers with spread checks green.

Resolution: closed resolved

Reason: The pull request was merged into the imagecraft main branch with 2 approving reviews and all spread job checks passing (only the unrelated OSV-scanner security scan failed). The merged test adds a Pi variant for the core spread boot tests, invoking the command twice for install and run mode since QEMU does not read cmdline.txt.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR adds a pi variant for the core spread boot tests. QEMU doesn't run the Pi firmware so we need to extract and pass the kernel, initrd and device tree. We also need to invoke the command twice, once for install mode and another for run mode. Snapd switches this in cmdline.txt but qemu doesnt not read cmdline.txt (the image works as is with a physical device) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #394 (smethnani) merged, adding a Pi core spread boot test that extracts and passes kernel, initrd and device tree to QEMU and runs install and run modes; approved by 2 reviewers with spread checks green.
stealth/space-bunny-alpha — closed resolved Merged canonical/imagecraft#394, adding Pi core spread boot tests that pass the kernel, initrd, and device tree to QEMU and exercise both install and run modes.
qwen/qwen3.6-35b-a3b — — Merged. Adds a Raspberry Pi variant to core spread boot tests, handling QEMU limits by extracting the kernel, initrd, and device tree, and running separate install and run modes. Approved by two reviewers and passed CI before merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 30
Confidence: 90
needs review Adds a Raspberry Pi variant for core spread boot tests to handle QEMU firmware and cmdline.txt limitations. Approved by 2 reviewers, CI mostly passing except OSV-scanner.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 35
Confidence: 85
needs review Adds a Raspberry Pi variant for core spread boot tests to handle QEMU firmware and cmdline.txt limitations. Approved by one reviewer, CI mostly passing except OSV-scanner, awaiting final review/merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 25
Confidence: 85
needs review Adds a Raspberry Pi variant for core spread boot tests to handle QEMU's lack of Pi firmware by extracting kernel/initrd/dtb and invoking commands for install/run modes. Currently pending maintainer review with CI mostly passing except OSV-scanner.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 85
needs review Adds a new spread test for Core Pi boot functionality. Currently awaiting maintainer review with CI mostly passing except for a security scan warning.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 15
Confidence: 85
needs review Adds a core Pi boot spread test (+140/-27 lines across 4 files). Currently pending maintainer review with zero comments. CI shows mixed results: core tests pass, but OSV scanner and root-required fast tests fail. Build jobs are pending.

Update history

Date Change
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#375 test: add core boot spread test imagecraft merged Merged PR #375 added an arm64 core-image boot spread suite, marked boot tests manual, and optimized classic arm64 QEMU arguments for faster startup.
81%