refactor(models): import _GrammarAwareModel from craft-application
Metadata
Current evaluation
PR closed without merging; duplicate _GrammarAwareModel remains in imagecraft/models/grammar.py. CI passed but snap builds were pending.
Resolution: closed stale
Reason: Closed by a maintainer with no explanation and no linked resolving PR or commit; current main still contains the duplicated _GrammarAwareModel definition, so the refactor was not applied.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Replaces the duplicated `_GrammarAwareModel` definition in `imagecraft.models.grammar` with the upstream definition from `craft_application.models.grammar`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| ~deepseek/deepseek-pro-latest | — | closed stale | PR closed without merging; duplicate _GrammarAwareModel remains in imagecraft/models/grammar.py. CI passed but snap builds were pending. | |
| ~deepseek/deepseek-pro-latest |
Impact:
25
Quick Win:
17
Complexity:
15
Confidence:
90
Actionability:
80
|
needs review | Replaces duplicated _GrammarAwareModel in imagecraft.models.grammar with upstream craft_application.models.grammar import; CI green, snap builds pending. |
Update history
| Date | Change |
|---|---|
| closed | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #312 refactor: update grammar models | craft-application | closed | Grammar-model refactor PR #312 was closed unmerged with one unresolved review comment; no resolving merge was recorded. |