← Back to issue list

refactor(pack): use craft-application YAML helpers in pack service

View original Github issue

Metadata

Project
imagecraft
Number
#478
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #478 refactors ImagecraftPackService to use craft-application safe_yaml_load and dump_yaml instead of direct yaml.safe_load/safe_dump.

Resolution: closed resolved

Reason: PR #478 was merged after approval and passing CI. It replaces direct yaml.safe_load/safe_dump usage in imagecraft/services/pack.py with craft_application.util.safe_yaml_load and craft_application.util.dump_yaml.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Replaces direct `yaml.safe_load` and `yaml.safe_dump` usage in `ImagecraftPackService` with `craft_application.util.safe_yaml_load` and `craft_application.util.dump_yaml`.

Evaluation history

Date Model Scores Action Summary
~deepseek/deepseek-pro-latest — closed resolved Merged PR #478 refactors ImagecraftPackService to use craft-application safe_yaml_load and dump_yaml instead of direct yaml.safe_load/safe_dump.
~deepseek/deepseek-pro-latest
Impact: 30
Quick Win: 23
Complexity: 15
Confidence: 85
Actionability: 90
needs review Replaces direct yaml.safe_load/safe_dump in ImagecraftPackService with craft-application safe_yaml_load/dump_yaml. Approved by 1 reviewer, CI green, +7/-7 lines in one file.
~deepseek/deepseek-pro-latest
Impact: 20
Quick Win: 11
Complexity: 30
Confidence: 78
Actionability: 80
needs review Replaces direct yaml.safe_load/safe_dump in ImagecraftPackService with craft_application.util.safe_yaml_load/dump_yaml; small refactor, CI passing, pending review.
~deepseek/deepseek-pro-latest
Impact: 25
Quick Win: 16
Complexity: 18
Confidence: 85
Actionability: 80
needs review Replaces direct yaml.safe_load/safe_dump in ImagecraftPackService with craft-application util.safe_yaml_load/dump_yaml. CI green, only snap-builds and a few test jobs pending; awaiting review.

Update history

Date Change
merged
updated
updated
created

Related issues

Issue Project State Summary Similarity
#4797 refactor: change PackCommand parent snapcraft merged PR #4797 merged as commit b6f464c78, reparenting snapcraft's PackCommand onto craft-application's PackCommand, deleting ~23 lines of duplicated code enabled by craft-application#340/#341.
70%