← Back to issue list

feat(template): use images command to poll docker daemon readiness

View original Github issue

Metadata

Project
rockcraft
Number
#1010
Type
pull request
State
open
Author
zhijie-yang
Labels
—
Created
Updated
Closed
—

Current evaluation

Changes the spread Docker readiness probe from pulling/running hello-world to listing local images to avoid registry rate limits; snap-tests and lint/files fail, with no activity for 344 days.

Suggested action: needs review

Reason: The current spread.yaml still uses docker run --rm hello-world, so this one-line fix remains relevant and is not superseded. However, snap-tests and lint / files are failing, and there has been no review or author response for 344 days, so maintainers need to determine whether the PR should be revived and the failures resolved.

Evaluated by: mr-cal-bot

Impact: 40 Quick Win: 7 Complexity: 8 Confidence: 84 Actionability: 20

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- This PR changes the polling command for the readiness of the Docker daemon from `docker run hello-world` to `docker images` to prevent rate limit exceeds when running `rockcraft test` in CI.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 40
Quick Win: 7
Complexity: 8
Confidence: 84
Actionability: 20
needs review Changes the spread Docker readiness probe from pulling/running hello-world to listing local images to avoid registry rate limits; snap-tests and lint/files fail, with no activity for 344 days.
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 6
Complexity: 5
Confidence: 60
Actionability: 30
close stale Changes Docker daemon readiness check from `docker run hello-world` to `docker images` in spread test template to avoid CI rate limits
qwen/qwen3.8-27b
Impact: 20
Quick Win: 19
Staleness: 75
Complexity: 5
Confidence: 80
needs review Swaps the Docker daemon readiness poll in the test init template from `docker run hello-world` to `docker images` to avoid Docker Hub rate limits in CI. 1-line change; 312 days inactive, 0 comments, 2 failing CI checks, target line still present at HEAD.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 10
Confidence: 75
close stale Changes Docker daemon readiness polling from docker run hello-world to docker images to prevent CI rate limits. Currently unreviewed, 272 days old, and has failing CI checks.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 10
Confidence: 70
needs review Changes Docker daemon readiness polling from docker run hello-world to docker images to prevent CI rate limits. The PR has been inactive for 257 days with zero maintainer comments.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 10
Confidence: 85
close stale Replaces docker run hello-world with docker images to poll Docker daemon readiness and avoid CI rate limits. PR remains unreviewed and inactive for over eight months.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.