← Back to issue list

fix: preserve xattrs in layers

View original Github issue

Metadata

Project
rockcraft
Number
#1016
Type
pull request
State
open
Author
bepri
Labels
—
Created
Updated
Closed
—

Current evaluation

Prototype fix preserving xattrs in ROCK layers by using GNU tar instead of Python tarfile (closes #683). Changes requested with 5 unresolved comments; lint, fast tests and snap-tests failing; no author activity in 324 days.

Suggested action: close stale

Reason: Review status is changes_requested with 5 unresolved review comments, 4 CI checks failing (lint / files, Fast tests on jammy and noble, snap-tests), and zero author activity for 324 days. The last reviewer comment from tigarmo ('I think we should try this [AI suggestion] next', 2025-11-12) steers toward a different implementation rather than this GNU tar prototype, and upstream rockcraft/layers.py has since been reworked (e.g. #1357 skip-repacking, ruff/lint migrations) while issue #683 is still open and the PR sits unaddressed — a stale prototype that should be closed in favor of a fresh approach.

Evaluated by: mr-cal-bot

Impact: 55 Quick Win: 3 Complexity: 62 Confidence: 84 Actionability: 12

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- Prototype implementation of xattr preservation using GNU tar in Rockcraft. The fix was tested locally using the reproducer in the linked issue. If reviewers are happy with the final implementation, I'll add a spread test confirming this behavior. Closes #683. ROCKCRAFT-282

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 55
Quick Win: 3
Complexity: 62
Confidence: 84
Actionability: 12
close stale Prototype fix preserving xattrs in ROCK layers by using GNU tar instead of Python tarfile (closes #683). Changes requested with 5 unresolved comments; lint, fast tests and snap-tests failing; no author activity in 324 days.
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 7
Complexity: 35
Confidence: 75
Actionability: 20
close stale Prototype fix preserving file xattrs in ROCK image layers via GNU tar; review changes requested with 5 unresolved comments, CI failing on fast tests and lint, inactive ~10 months.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 27
Staleness: 68
Complexity: 40
Confidence: 70
close stale Prototype fix preserving file xattrs in ROCK image layers via GNU tar; closes #683. Review requested changes (5 unresolved comments), CI failing on fast tests and lint; inactive ~10 months since a maintainer asked for a different approach.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 25
Confidence: 85
close stale Prototype PR implementing xattr preservation in Rockcraft layers via GNU tar. Currently has 5 unresolved review comments, failing CI tests, and a reviewer suggested an alternative approach.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 45
Confidence: 85
close stale Prototype implementation to preserve xattrs in layers using GNU tar. Inactive for over 8 months with a maintainer suggesting an alternative approach.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 40
Confidence: 70
close stale Prototype implementation to preserve extended attributes in layers using GNU tar. Inactive for 234 days with a maintainer suggesting an alternative approach.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#683 (confidence 95%)

    Bug report this PR declares it closes; the issue remains open in the pinned tree, with layers.py still using Python tarfile and no xattr handling.

  • Related To: tigarmo/rockcraft#3 (confidence 60%)

    Reviewer tigarmo pointed to an alternative 'AI suggestion' comment in this fork issue, implying a different implementation path should be tried instead of this prototype.

Related issues

Issue Project State Summary Similarity
#683 File capabilities (xattrs) are not preserved in final ROCK image layers. rockcraft open Maintainer-acknowledged bug with a complete reproducer: security.capability xattrs on primed files are lost when ROCK image layers are packaged
73%