← Back to issue list

fix: preserve xattrs in layers

View original Github issue

Metadata

Project
rockcraft
Number
#1016
Type
pull request
State
open
Author
bepri
Labels
—
Created
Updated
Closed
—

Current evaluation

Prototype fix preserving file xattrs in ROCK image layers via GNU tar; closes #683. Review requested changes (5 unresolved comments), CI failing on fast tests and lint; inactive ~10 months since a maintainer asked for a different approach.

Suggested action: close stale

Reason: The PR has been in changes_requested state with 5 unresolved review comments, and the last activity (292 days ago) was reviewer tigarmo asking the author to try a different approach ('I think we should try this AI suggestion next') — the author never responded, far exceeding the 3-month window. Failing CI (snap-tests, fast tests on jammy/noble, lint/files) plus the rejected GNU tar approach mean this specific implementation is no longer viable, though issue #683 itself remains open.

Impact: 45 Quick Win: 27.0 Staleness: 68 Complexity: 40 Confidence: 70

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- Prototype implementation of xattr preservation using GNU tar in Rockcraft. The fix was tested locally using the reproducer in the linked issue. If reviewers are happy with the final implementation, I'll add a spread test confirming this behavior. Closes #683. ROCKCRAFT-282

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 45
Quick Win: 27.0
Staleness: 68
Complexity: 40
Confidence: 70
close stale Prototype fix preserving file xattrs in ROCK image layers via GNU tar; closes #683. Review requested changes (5 unresolved comments), CI failing on fast tests and lint; inactive ~10 months since a maintainer asked for a different approach.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 25
Confidence: 85
close stale Prototype PR implementing xattr preservation in Rockcraft layers via GNU tar. Currently has 5 unresolved review comments, failing CI tests, and a reviewer suggested an alternative approach.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 45
Confidence: 85
close stale Prototype implementation to preserve xattrs in layers using GNU tar. Inactive for over 8 months with a maintainer suggesting an alternative approach.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 40
Confidence: 70
close stale Prototype implementation to preserve extended attributes in layers using GNU tar. Inactive for 234 days with a maintainer suggesting an alternative approach.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 25
Confidence: 75
close stale Prototype preserving extended attributes in Rockcraft layers using GNU tar. Locally tested and awaiting review. Currently paused as a reviewer suggested exploring an alternative approach first.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#683 (confidence 95%)

    PR body states 'Closes #683' (file capabilities/xattrs not preserved in final ROCK image layers); the issue is still open, so the underlying bug is unresolved even if this PR is closed.

Related issues

Issue Project State Summary Similarity
#683 File capabilities (xattrs) are not preserved in final ROCK image layers. rockcraft open File capabilities (xattrs) set via setcap during ROCK build are dropped in final image layers because Python tarfile does not preserve xattrs. Acknowledged by maintainer; a fix PR (#1016) is open but stalled with unresolved review comments and CI failures.
77%