← Back to issue list

docs: clean up 'rockcraft.yaml'

View original Github issue

Metadata

Project
rockcraft
Number
#1056
Type
pull request
State
merged
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1056 as commit 32d800b9, upgrading pydantic-kitbash to v0.1.1 and cleaning rockcraft.yaml docs by removing redundant modules and normalizing field order.

Resolution: closed resolved

Reason: PR #1056 was approved and merged into main as commit 32d800b9. The maintainer confirmed the remaining spread-test failures were unrelated.

Evaluated by: mr-cal-bot

No scores available.

Issue body

* Upgrade pydantic-kitbash to v0.1.1 * Remove unnecessary module declarations * Normalize field order with the other crafts --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1056 as commit 32d800b9, upgrading pydantic-kitbash to v0.1.1 and cleaning rockcraft.yaml docs by removing redundant modules and normalizing field order.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#1056 as 32d800b9: cleaned rockcraft.yaml docs, upgraded pydantic-kitbash to v0.1.1, removed redundant module declarations, and aligned field order.
qwen/qwen3.6-35b-a3b — — Merged documentation cleanup for rockcraft.yaml. Updates include upgrading pydantic-kitbash to v0.1.1, removing unnecessary module declarations, and normalizing field order. Approved by two reviewers and merged despite unrelated snap-test failures.
qwen3.6-35b-a3b-mtp-q6 — — Merged documentation cleanup for rockcraft.yaml. Changes upgrade pydantic-kitbash to v0.1.1, remove unnecessary module declarations, and normalize field order. CI failures were unrelated to these documentation updates.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#1041 (confidence 95%)

    Introduced KitBash-generated rockcraft.yaml documentation that PR #1056 cleaned up.

  • Related To: canonical/rockcraft#1075 (confidence 90%)

    Later upgraded pydantic-kitbash from this work to v1.0.0.

Related issues

Issue Project State Summary Similarity
#1041 docs: generate 'rockcraft.yaml' with kitbash rockcraft merged Merged PR #1041 as fd28a343, generating the rockcraft.yaml reference from Pydantic KitBash models and closing canonical/open-documentation-academy#304.
82%
#289 docs: expand rockcraft.yaml reference rockcraft merged Merged into main via commit 654c9c01, reorganizing reference docs and expanding the rockcraft.yaml configuration reference across seven files.
77%
#6 project: add basic rockcraft.yaml parsing and validation (CRAFT-584) rockcraft merged Merged in rockcraft PR #6 (88c9d529), adding rockcraft.yaml parsing and parts validation, renaming tag to version, and switching output from .oci.tar to .rock.
74%
#682 docs: fix typo rockcraft merged Merged rockcraft#682 (commit 371bc723) fixing a one-line documentation typo; approved by 3 reviewers, CLA signed, merged.
73%
#105 docs: add commands rockcraft merged Merged PR #105 as commit 68906471, adding the first draft of rockcraft command documentation and resolving issue #101.
73%
#559 docs: use canonical-sphinx rockcraft merged Merged PR #559 (commit 041e3137) switched Rockcraft docs to canonical-sphinx, added the dependency to setup.cfg, and regenerated requirements-doc.txt.
73%
#101 docs for `rockcraft clean` rockcraft closed Documentation for `rockcraft clean` was requested after #93 added the command in c4502a7a, but no resolving docs PR or commit was identified before closure.
72%
#5924 docs: clean up 'snapcraft.yaml' snapcraft merged Merged snapcraft.yaml documentation cleanup in #5924 via commit 83f961ebc, upgrading pydantic-kitbash, correcting docstrings and links, and regenerating the JSON schema.
72%
#5665 docs: clean up 'snapcraft.yaml' snapcraft merged Merged docs cleanup in #5665 (30ab2b049): upgraded pydantic-kitbash to 0.0.7, removed library modules from sys.path, and declared currentmodule for Part Properties.
72%
#1187 docs: release notes for 1.18 rockcraft merged Merged PR #1187 in commit 0bd07273, adding Rockcraft 1.18 release notes across three documentation files.
72%