← Back to issue list

docs: clean up 'rockcraft.yaml'

View original Github issue

Metadata

Project
rockcraft
Number
#1056
Type
pull request
State
merged
Author
jahn-junior
Labels
Created
Updated
Closed

Current evaluation

Merged documentation cleanup for rockcraft.yaml. Updates include upgrading pydantic-kitbash to v0.1.1, removing unnecessary module declarations, and normalizing field order. Approved by two reviewers and merged despite unrelated snap-test failures.

Suggested action:

No scores available.

Issue body

* Upgrade pydantic-kitbash to v0.1.1 * Remove unnecessary module declarations * Normalize field order with the other crafts --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged documentation cleanup for rockcraft.yaml. Updates include upgrading pydantic-kitbash to v0.1.1, removing unnecessary module declarations, and normalizing field order. Approved by two reviewers and merged despite unrelated snap-test failures.
qwen3.6-35b-a3b-mtp-q6 Merged documentation cleanup for rockcraft.yaml. Changes upgrade pydantic-kitbash to v0.1.1, remove unnecessary module declarations, and normalize field order. CI failures were unrelated to these documentation updates.
qwen3.6-35b-a3b-mtp-q6 Merged documentation cleanup for rockcraft.yaml. Changes include upgrading pydantic-kitbash to v0.1.1, removing unnecessary module declarations, and normalizing field order. Unrelated test failures did not block the merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1041 docs: generate 'rockcraft.yaml' with kitbash rockcraft merged Merged documentation update generating rockcraft.yaml via kitbash. Changes fixed broken links, added configuration keys beyond Snapcraft, and passed CI checks following reviewer approval.
84%
#289 docs: expand rockcraft.yaml reference rockcraft merged Merged after three reviewers approved, the PR reorganized the documentation reference section and expanded the rockcraft.yaml reference guide, modifying 7 files.
78%
#5665 docs: clean up 'snapcraft.yaml' snapcraft merged Merged documentation cleanup for snapcraft.yaml. Updated pydantic-kitbash to v0.0.7, removed library modules from sys.path, and added currentmodule directives to resolve Kitbash warnings. Approved by two reviewers, passed CI, and modified four files.
77%
#400 fix(docs): make sure we can build the example rockcraft.yaml rockcraft merged Merged to resolve issue #399. Added a spread test validating the example rockcraft.yaml build process for documentation. Approved by three reviewers and passed all CI checks.
76%
#245 docs: clean up 'imagecraft.yaml' imagecraft merged Merged documentation cleanup for imagecraft.yaml. Updates include upgrading pydantic-kitbash to v0.1.1, removing legacy workarounds, fixing typos, and refining docstrings. Approved by two reviewers and successfully merged.
75%
#323 docs: Add explanation on the Hello-world tutorial rockcraft merged Merged documentation update explaining the rockcraft.yaml file in the Hello World tutorial. Approved by three reviewers, the change adds 26 lines and removes 9 across two files.
75%
#6 project: add basic rockcraft.yaml parsing and validation (CRAFT-584) rockcraft merged Merged changes adding rockcraft.yaml parsing and validation to halt builds on invalid parts. Renamed the tag field to version and updated the output image suffix to .rock. Approved and passed CI across seven files.
75%
#105 docs: add commands rockcraft merged Merged documentation adding rockcraft commands, resolving issue #101. After initial review requested changes, the maintainer coordinated with reviewers and merged the first draft.
74%
#310 docs: fix url of rockcraft format rockcraft merged Merged a documentation fix correcting a broken URL in convert-to-pebble-layer.rst, resolving a linkcheck failure. Approved by two reviewers, passed CI, and modified one file.
74%
#1093 feat(snap): add rockcraft.json to the snap rockcraft merged Merged a pull request adding rockcraft.json to the snap. Requested by the Rocks team, this enables users to validate rockcraft.yaml against their installed version and check supported bases. Approved by two reviewers and passed CI checks.
73%