← Back to issue list

spread: check that UBUNTU_PRO_TOKEN is set

View original Github issue

Metadata

Project
rockcraft
Number
#1071
Type
pull request
State
open
Author
tigarmo
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds a spread test guard for missing UBUNTU_PRO_TOKEN; open 253 days, no reviewers, CI failing, and current main already contains the check.

Suggested action: close superseded

Reason: Current main's spread.yaml already contains the exact "if [ -z "$UBUNTU_PRO_TOKEN" ]; then echo "Error: UBUNTU_PRO_TOKEN is not set."; exit 1; fi" guard in tests/spread/pro/ prepare, introduced by canonical/rockcraft#1184 (commit 1987d98b). PR #1071 has been open 253 days with no activity and multiple failing CI checks.

Evaluated by: mr-cal-bot

Impact: 10 Quick Win: 1 Complexity: 5 Confidence: 80 Actionability: 10

Issue body

<!-- Describe your changes --> --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
~deepseek/deepseek-pro-latest
Impact: 10
Quick Win: 1
Complexity: 5
Confidence: 80
Actionability: 10
close superseded Adds a spread test guard for missing UBUNTU_PRO_TOKEN; open 253 days, no reviewers, CI failing, and current main already contains the check.
~deepseek/deepseek-pro-latest
Impact: 15
Quick Win: 3
Complexity: 5
Confidence: 60
Actionability: 20
close stale Adds a guard checking UBUNTU_PRO_TOKEN is set in the pro validation spread test. 253 days old, no comments or reviewers, CI broadly failing.
qwen/qwen3.6-35b-a3b
Impact: 10
Quick Win: 1
Complexity: 5
Confidence: 75
Actionability: 10
close stale Adds a check for UBUNTU_PRO_TOKEN in spread test configuration. Open 239 days with no activity, no reviewers, and multiple CI failures.
qwen/qwen3.8-27b
Impact: 10
Quick Win: 10
Staleness: 75
Complexity: 5
Confidence: 80
close stale Adds UBUNTU_PRO_TOKEN check to spread.yaml. Inactive 222 days, 0 reviews, CI failing. The check is already present in the codebase via the feature/pro-sources merge (#1184).
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 10
Confidence: 75
close stale Adds a check for UBUNTU_PRO_TOKEN in spread tests. Currently inactive for 6 months, failing CI, and awaiting review.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 10
Confidence: 80
close stale Adds a check for the UBUNTU_PRO_TOKEN environment variable in the spread test configuration. Currently inactive for 167 days with no comments or updates.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 15
Confidence: 60
needs review Adds a check for the UBUNTU_PRO_TOKEN environment variable in the spread testing configuration. Currently inactive for 164 days with no comments or CI status.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/rockcraft#1184 (confidence 85%)

    Current main spread.yaml already contains the UBUNTU_PRO_TOKEN check; #1184 merged feature/pro-sources into main and introduced it.

Related issues

No related issues found above the similarity threshold.