← Back to issue list

feat: default to bare base for django extension

View original Github issue

Metadata

Project
rockcraft
Number
#1083
Type
pull request
State
closed
Author
arturo-seijas
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; its Django bare-base change was superseded by merged PR canonical/rockcraft#1086 (commit 3fba20c2), covering Django, Flask, and FastAPI.

Resolution: closed superseded

Reason: PR #1083 was closed without merging because #1086 delivered the change more broadly for Django, Flask, and FastAPI. The replacement was merged in commit 3fba20c2.

Evaluated by: mr-cal-bot

No scores available.

Issue body

<!-- Describe your changes --> Default to bare base for django extension: Also adds a symlink sh -> bash so that `juju ssh` can work --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; its Django bare-base change was superseded by merged PR canonical/rockcraft#1086 (commit 3fba20c2), covering Django, Flask, and FastAPI.
stealth/space-bunny-alpha — closed superseded Closed unmerged; #1086 superseded it by defaulting Django, Flask, and FastAPI extensions to a bare base in commit 3fba20c2.
stealth/space-bunny-alpha — closed superseded Closed unmerged. Maintainer PR #1083 (django bare base + sh->bash symlink) was folded into merged PR #1086 (commit 3fba20c2) covering Flask, Django and FastAPI; the sh symlink landed separately in #1092 (c94543f0).
stealth/space-bunny-alpha — closed superseded Closed unmerged; the Django bare-base change was delivered for Django, Flask, and FastAPI by merged PR #1086 (commit 3fba20c2).
qwen/qwen3.6-35b-a3b — — Changes to default to a bare base for the django extension and add a symlink were closed without merging. Failing CI checks and zero review activity indicate the contribution was abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging, likely abandoned. The contribution proposed defaulting to bare base for the Django extension and adding a sh-to-bash symlink for juju ssh compatibility.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/rockcraft#1086 (confidence 99%)

    Merged replacement PR, in commit 3fba20c2, defaults Flask, Django, and FastAPI extension initialization to a bare base.

Related issues

Issue Project State Summary Similarity
#1087 feat: default to bare base for flask extension rockcraft closed Closed in favor of canonical/rockcraft#1086, which merged as commit 3fba20c2 and expanded the bare-base default to Flask, Django, and FastAPI extensions.
91%
#1079 Default to bare base for django extension rockcraft closed Closed unmerged and superseded by #1086, which merged commit 3fba20c2 to default the Flask, Django, and FastAPI extensions to a bare base.
86%
#1084 feat: default to bare base for fastapi extension rockcraft closed Superseded by #1086, merged in commit 3fba20c2 to default Flask, Django, and FastAPI extensions to bare bases.
84%
#1086 feat: default to bare base for flask, django and fastapi extensions rockcraft merged Merged in rockcraft#1086 via commit 3fba20c2, making Flask, Django, and FastAPI extensions default to bare base to reduce image size and attack surface.
83%