← Back to issue list

feat: extensions compatibility with upstream tutorials

View original Github issue

Metadata

Project
rockcraft
Number
#1090
Type
pull request
State
merged
Author
f-atwi
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1090 as commit 4087b095, adding Flask pyproject.toml support and improved Flask/Django app detection for upstream tutorials.

Resolution: closed resolved

Reason: PR #1090 was approved and merged with all CI checks passing; commit 4087b095 records the resolution. The changes added Flask pyproject.toml support and improved Flask and Django app discovery.

Evaluated by: mr-cal-bot

No scores available.

Issue body

<!-- Describe your changes --> Fixing compatibility of upstream tutorial apps with charmcraft 12-factor tutorials. - Flask: - support for pyproject.toml - improving app detection (different file, modules, names, and in factory methods) - django - app discovery (seach for a project called mysite to be compatible with the django tutorial) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1090 as commit 4087b095, adding Flask pyproject.toml support and improved Flask/Django app detection for upstream tutorials.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#1090 (4087b095), adding Flask pyproject.toml support and broader Flask/Django app detection for upstream tutorials.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#1090 (commit 4087b095), adding Flask pyproject.toml support and improved Flask/Django app detection for upstream tutorials.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#1090 via 4087b095, adding Flask pyproject.toml support and improved app detection plus Django mysite discovery for upstream Charmcraft 12-factor tutorials.
stealth/space-bunny-alpha — closed resolved Merged PR added Flask pyproject.toml support and broader app detection, plus Django mysite discovery for compatibility with upstream Charmcraft tutorials.
qwen/qwen3.6-35b-a3b — — Merged after reviewer approval and passing CI checks. Updated extensions to support upstream Flask and Django tutorials by adding pyproject.toml support, improving app detection, and enabling Django project discovery.
qwen3.6-35b-a3b-mtp-q6 — — Merged after review. Updated extensions to support upstream Flask and Django tutorials via pyproject.toml support and improved app detection. Changes passed linting and testing before final merge.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.