← Back to issue list

go-framework: fail early when no Go sources are present

View original Github issue

Metadata

Project
rockcraft
Number
#1114
Type
pull request
State
open
Author
gcomneno
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds an early check in go-framework's _check_project() that the project contains at least one .go file, raising an ExtensionError otherwise; unit tests updated with a minimal main.go. Open217 days, no maintainer review.

Suggested action: needs review

Reason: The diff is small and self-contained (one extra guard next to the existing go.mod check in rockcraft/extensions/go.py:113, plus test fixtures), and the author reports '16 passed' with clean Ruff locally across three follow-ups. However, review status is 'pending (0 reviewers)' with no CI checks recorded at all (passing/failing/pending all none), and three pings (2026-05-24, 2026-06-30, 2026-08-31) went unanswered, so there is no maintainer signal or green-CI evidence; the docs page docs/reference/extensions/go-framework.rst (#project-requirements) was not updated to state the new requirement, which a reviewer would likely request. Inactivity alone is not grounds to close since the author states the branch is still mergeable and rebased.

Evaluated by: mr-cal-bot

Impact: 30 Quick Win: 15 Complexity: 15 Confidence: 72 Actionability: 58

Issue body

This change makes the go-framework extension validate that the project contains at least one Go source file. Motivation: projects with a go.mod but no .go files can otherwise reach later stages and fail with lower-level errors. Unit tests were updated to add a minimal main.go in valid test cases.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 30
Quick Win: 15
Complexity: 15
Confidence: 72
Actionability: 58
needs review Adds an early check in go-framework's _check_project() that the project contains at least one .go file, raising an ExtensionError otherwise; unit tests updated with a minimal main.go. Open217 days, no maintainer review.
qwen/qwen3.6-35b-a3b
Impact: 40
Quick Win: 24
Complexity: 15
Confidence: 75
Actionability: 70
needs review Adds validation to go-framework extension to fail early when no .go source files are present alongside go.mod. Author has rebased, tests pass locally, awaiting maintainer review.
qwen/qwen3.8-27b
Impact: 25
Quick Win: 21
Staleness: 45
Complexity: 15
Confidence: 75
needs review Adds go-framework extension validation to fail early when go.mod exists but no .go source files are present. Small diff (+49/-1, 2 files), CI passing, rebased on main. Pending maintainer review after 186 days with 3 author pings and zero maintainer engagement.
qwen/qwen3.6-35b-a3b
Staleness: 65
Complexity: 10
Confidence: 85
needs review Adds validation to fail early if a Go project contains go.mod but no .go files. Small diff, CI passes, but pending maintainer review after two contributor pings over the past month.
qwen3.6-35b-a3b-mtp-q6
Staleness: 40
Complexity: 10
Confidence: 85
needs review Adds validation to the go-framework extension to fail early if a project contains go.mod but no .go files. Includes updated unit tests. Currently awaiting maintainer review after contributor rebased and verified local checks.
qwen3.6-35b-a3b-mtp-q6
Staleness: 15
Complexity: 10
Confidence: 85
needs review Adds validation to the go-framework extension to ensure projects contain at least one Go source file, preventing downstream errors. Awaiting maintainer review after author's recent rebase and local test confirmation.

Update history

Date Change
updated
updated

Related issues

No related issues found above the similarity threshold.