← Back to issue list

go-framework: fail early when no Go sources are present

View original Github issue

Metadata

Project
rockcraft
Number
#1114
Type
pull request
State
open
Author
gcomneno
Labels
Created
Updated
Closed

Current evaluation

Adds go-framework extension validation to fail early when go.mod exists but no .go source files are present. Small diff (+49/-1, 2 files), CI passing, rebased on main. Pending maintainer review after 186 days with 3 author pings and zero maintainer engagement.

Suggested action: needs review

Reason: The PR is small, follows the established validation pattern used by other extensions (expressjs, fastapi, gunicorn all have similar 'missing file' checks), CI passes, and the author has rebased onto current main with all focused tests passing (16 passed, Ruff clean). However, it has sat for 186 days with zero maintainer interaction despite three author follow-ups (May, June, August 2026). The change is still relevant — the current go.py _check_project only validates go.mod existence, not .go file presence — and the PR is mergeable, so it warrants a maintainer review rather than closure.

Impact: 25 Quick Win: 21.25 Staleness: 45 Complexity: 15 Confidence: 75

Issue body

This change makes the go-framework extension validate that the project contains at least one Go source file. Motivation: projects with a go.mod but no .go files can otherwise reach later stages and fail with lower-level errors. Unit tests were updated to add a minimal main.go in valid test cases.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 25
Quick Win: 21.25
Staleness: 45
Complexity: 15
Confidence: 75
needs review Adds go-framework extension validation to fail early when go.mod exists but no .go source files are present. Small diff (+49/-1, 2 files), CI passing, rebased on main. Pending maintainer review after 186 days with 3 author pings and zero maintainer engagement.
qwen/qwen3.6-35b-a3b
Staleness: 65
Complexity: 10
Confidence: 85
needs review Adds validation to fail early if a Go project contains go.mod but no .go files. Small diff, CI passes, but pending maintainer review after two contributor pings over the past month.
qwen3.6-35b-a3b-mtp-q6
Staleness: 40
Complexity: 10
Confidence: 85
needs review Adds validation to the go-framework extension to fail early if a project contains go.mod but no .go files. Includes updated unit tests. Currently awaiting maintainer review after contributor rebased and verified local checks.
qwen3.6-35b-a3b-mtp-q6
Staleness: 15
Complexity: 10
Confidence: 85
needs review Adds validation to the go-framework extension to ensure projects contain at least one Go source file, preventing downstream errors. Awaiting maintainer review after author's recent rebase and local test confirmation.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 15
Confidence: 85
needs review Validates Go projects contain at least one source file before proceeding, preventing lower-level failures. Tests and linting pass. Awaiting review.

Update history

Date Change
updated
updated

Related issues

No related issues found above the similarity threshold.