← Back to issue list

build(deps): unpin setuptools-scm

View original Github issue

Metadata

Project
rockcraft
Number
#1164
Type
pull request
State
closed
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

PR #1164 proposed removing the setuptools-scm workaround after the upstream bug was fixed, but closed unmerged with review pending and no recorded resolution; the constraint remains.

Resolution: closed stale

Reason: All CI checks passed, but no merge commit or closing explanation was recorded, and pyproject.toml still contains the workaround introduced by #1158 in commit 01ecfcd3. The unpin was therefore abandoned after inactivity.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The upstream bug was fixed. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale PR #1164 proposed removing the setuptools-scm workaround after the upstream bug was fixed, but closed unmerged with review pending and no recorded resolution; the constraint remains.
stealth/space-bunny-alpha — closed stale The proposed setuptools-scm unpin was closed without a recorded merge after the upstream fix; CI passed, but review remained pending and no closing rationale was provided.
qwen/qwen3.6-35b-a3b — — Merged after the upstream bug was fixed. The setuptools-scm dependency pin was removed, and all CI checks passed.
qwen3.6-35b-a3b-mtp-q6 — — Closed as superseded because the upstream setuptools-scm bug was resolved, making the dependency unpinning unnecessary. The PR was not merged.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#1158 (confidence 100%)

    Merged as commit 01ecfcd3 and added the setuptools-scm constraint that #1164 proposed removing.

  • Related To: canonical/rockcraft#1157 (confidence 99%)

    Merged as commit 3e5b3347 and introduced the original setuptools-scm build constraint.

  • Related To: setuptools-scm#1302 (confidence 98%)

    Upstream cyclic-dependency bug cited by the constraint; its reported fix motivated the unpin attempt.

Related issues

Issue Project State Summary Similarity
#309 build(deps): unpin setuptools-scm imagecraft merged Merged #309 in commit b1e78bf, removing the setuptools-scm pin after the upstream cyclic-dependency bug was fixed.
83%
#6131 build(deps): unpin setuptools-scm snapcraft merged Merged #6131 in commit d7872467d, removing the setuptools-scm pin after the upstream fix landed in setuptools-scm 10.0.5.
82%
#1158 build(deps): constrain setuptools-scm due to cyclic dependency rockcraft merged Merged PR #1158 as commit 01ecfcd3, adding a setuptools-scm constraint to work around pypa/setuptools-scm#1302 and unblock dependency synchronization.
78%
#306 build(deps): constrain setuptools-scm due to cyclic dependency imagecraft merged Merged as fca3ff4, adding a temporary setuptools-scm constraint to work around pypa/setuptools-scm#1302's cyclic-dependency bug; #309 later removed the pin after the upstream fix.
78%
#110 build(deps): unpin setuptools-scm debcraft merged Merged canonical/debcraft#110 as commit 63d83cb, removing the temporary setuptools-scm pin after its upstream cyclic-dependency bug was fixed.
78%
#2602 build(deps): constrain setuptools-scm due to cyclic dependency charmcraft merged Merged PR #2602 (commit f9c9ad06) adding a temporary setuptools-scm version constraint to work around the cyclic dependency in pypa/setuptools-scm#1302. The pin was later removed by #2615.
77%
#6123 build(deps): constrain setuptools-scm due to cyclic dependency snapcraft merged PR #6123 by lengau merged as commit 22682ed3c, adding a temporary setuptools-scm pin to work around pypa/setuptools-scm#1302 cyclic dependency. Later reverted by #6131 (d7872467d).
77%
#105 build(deps): constrain setuptools-scm due to cyclic dependency debcraft merged Merged in commit 30bdea8, temporarily constraining setuptools-scm to work around pypa/setuptools-scm#1302; debcraft#110 later removed the constraint.
76%
#2615 build(deps): unpin setuptools-scm charmcraft merged Merged in canonical/charmcraft#2615 at e78c495b, removing the temporary setuptools-scm pin after the upstream cyclic-dependency bug was fixed.
75%
#6130 build: constrain setuptools-scm<10.0.2 snapcraft closed Closed unmerged. The <10.0.2 constraint was made moot when setuptools-scm 10.0.5+ fixed pypa/setuptools-scm#1302 (#1330); PR #6131 (commit d7872467d) then removed the earlier pin from #6123 entirely.
73%