fix(pebble): avoid pydantic warning for exec checks
Metadata
Current evaluation
Fixes PydanticSerializationUnexpectedValue warning in Project.marshal() by making the pebble check discriminator accept already-validated check models; adds a unit test for exec checks. CI green so far, awaiting review.
Suggested action: needs review
Reason: Small, focused diff (+45/-4, 2 files) addressing the reproduced warning in issue #1154, with all completed CI checks passing (fast tests, lint, schema checks) and no unresolved review threads. The author rebased onto current main at 1d898ec and reports 80 passing unit tests locally; remaining pending jobs are build/slow-test jobs and unrelated failures. It has sat162 days with 0 reviewers, so it needs a maintainer to actually review/approve.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha |
Impact:
35
Quick Win:
20
Complexity:
20
Confidence:
82
Actionability:
72
|
needs review | Fixes PydanticSerializationUnexpectedValue warning in Project.marshal() by making the pebble check discriminator accept already-validated check models; adds a unit test for exec checks. CI green so far, awaiting review. | |
| qwen/qwen3.6-35b-a3b |
Impact:
55
Quick Win:
37
Complexity:
15
Confidence:
85
Actionability:
80
|
needs review | Fixes PydanticSerializationUnexpectedValue warning during Project.marshal() with exec checks. CI passing, awaiting maintainer review. | |
| qwen/qwen3.6-35b-a3b |
Impact:
45
Quick Win:
34
Staleness:
65
Complexity:
25
Confidence:
70
|
needs review | Fixes PydanticSerializationUnexpectedValue warning during Project.marshal() with exec checks. Small fix (+45/-4 lines, 2 files) with a unit test. CI passing, no reviewers yet, author followed up 3 times over 144 days. | |
| qwen/qwen3.6-35b-a3b |
Impact:
45
Quick Win:
38
Staleness:
10
Complexity:
15
Confidence:
75
|
needs review | Fixes PydanticSerializationUnexpectedValue warning during Project.marshal() with exec health checks. Author has rebased, tests pass, 0 reviewers, pending review. | |
| qwen/qwen3.8-27b |
Impact:
35
Quick Win:
28
Staleness:
45
Complexity:
20
Confidence:
82
|
needs review | Fixes PydanticSerializationUnexpectedValue warning when marshalling projects with exec checks by handling already-validated models in the check discriminator; adds unit test. Closes #1154. Rebased on main, author active; awaiting review, minor CI failures. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
25
Complexity:
15
Confidence:
85
|
needs review | Fixes Pydantic serialization warning for exec checks by handling already-validated models during marshalling. Adds unit test. Currently awaiting maintainer review with minor failing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
15
Complexity:
20
Confidence:
85
|
keep open | Fix Pydantic serialization warning for exec checks by updating the check discriminator during marshalling. Includes unit tests and passes local linting. Recently rebased and actively maintained. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
10
Complexity:
20
Confidence:
90
|
needs review | Fixes Pydantic serialization warning for exec health checks by updating the check discriminator logic. Includes unit tests and passes linting. Awaiting final maintainer review after recent rebase and applied patch. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated |
Related work
-
Likely Fixed By:
canonical/rockcraft#1154
(confidence 92%)
PR body explicitly says 'closes #1154'; that issue is still open and describes the same PydanticSerializationUnexpectedValue warning in Project.marshal() with exec checks.
Related issues
No related issues found above the similarity threshold.