← Back to issue list

ci: make workflows conditional, add docs-only spread tests

View original Github issue

Metadata

Project
rockcraft
Number
#1205
Type
pull request
State
closed
Author
medubelko
Labels
—
Created
Updated
Closed

Current evaluation

Superseded by merged PR canonical/rockcraft#1206 (commit 3624f64c), which implemented conditional CI and split source and docs Spread tests.

Resolution: closed superseded

Reason: The requested workflow changes landed through canonical/rockcraft#1206, recorded in commit 3624f64c. That implementation made checks conditional on source changes and separated source and documentation Spread test runs.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Make workflows conditional: - The full lint job only runs if source files are changed. - The Spread and test workflows only run if source files are changed. - The Spread workflow only runs the `test/**` Spread tests. Add a docs Spread workflow that runs the `docs/**` Spread tests. With the QA workflow, if there's a change to the source, all linters run in one runner (`make lint`). But for the Spread tests, there's a hard split between the docs and source Spread tests, meaning each will spawn their own runner. This isn't bad, but it adds complexity and inconsistency between the different workflow types. If Starflow's workflows were completely split, we could properly partition the checks in both collections (QA source, QA docs, Spread source, Spread docs). --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Superseded by merged PR canonical/rockcraft#1206 (commit 3624f64c), which implemented conditional CI and split source and docs Spread tests.
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#1206 (commit 3624f64c): CI workflows became source-change conditional, with separate docs-only and source-only Spread test runs.
qwen/qwen3.6-35b-a3b — — Closed without merging. The changes to conditional CI workflows and docs-only Spread tests remained pending review with unresolved comments and failing snap-tests. The PR was likely abandoned or superseded.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes to condition CI workflows on file changes and add a docs-only Spread test workflow. Source and docs tests now run in separate runners, improving consistency and reducing unnecessary CI execution.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/rockcraft#1206 (confidence 100%)

    Merged implementation of the same CI and Spread-test changes; commit 3624f64c cites PR #1206.

Related issues

Issue Project State Summary Similarity
#1206 ci: make workflows conditional, add docs-only spread tests rockcraft merged Merged in canonical/rockcraft#1206 at commit 3624f64c, adding path-conditional CI and separate source and docs-only Spread workflows.
95%
#6245 ci: make workflows conditional, add docs-only spread tests snapcraft merged Merged in #6245 via commit 40af3e5b5, adding path-conditional workflows and a docs-only Google-backed Spread test workflow.
80%
#2688 ci: make workflows conditional on affected files charmcraft merged PR #2688 merged as commit a32937a6: added paths-ignore conditions so QA/Test, Check policy, Experimental, Tests and Spread workflows only run on affected files; Split Spread into 'Spread tests for source' and docs.
76%
#6244 ci: test docs-conditional workflows and jobs snapcraft closed Closed unmerged; its docs-conditional CI approach was superseded by merged PR snapcraft#6245 in commit 40af3e5b5.
75%
#571 ci: use self-hosted runners for ci workflows rockcraft closed Closed unmerged and superseded by PR #573, whose commit c8ff5823 moved spread tests to self-hosted runners labeled spread-enabled.
72%
#2126 ci(docs): spread test documentation charmcraft merged Merged PR #2126 in commit f1b73a6e, adding CI for documentation spread tests and adapting spread tasks for Google-hosted runners.
71%
#1131 ci: skip QA and Spread workflows for security-scanner-only PRs craft-application merged Merged in canonical/craft-application#1131 (commit d8885203), adding paths-ignore filters so QA and Spread workflows skip security-scanner-only PRs; test follow-up #1132 was closed as unnecessary.
71%
#519 spread: reorganize spread tests rockcraft merged Merged PR #519 as commit 90d85343, consolidating most spread tests in the renamed rockcraft suite on Jammy VMs and adding a foreign suite for cross-system tests.
71%
#352 ci: add conditionals for docs-only checks imagecraft merged Merged CRAFT-5161 CI changes in #352 (commit 0104193), adding conditionals to skip required checks and unnecessary operations for docs-only changes.
70%
#143 docs: make docs spread-testable craft-store merged Merged PR #143 as commit 1676433, adding infrastructure to manually spread-test the restructured documentation without running docs spread tests in CI.
70%